add i10-1 and i06-1magnet temperature controller - #2121
Merged
oliwenmandiamond merged 92 commits intoAug 18, 2026
Conversation
5 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2121 +/- ##
========================================
Coverage 99.19% 99.20%
========================================
Files 364 367 +3
Lines 14379 14535 +156
========================================
+ Hits 14263 14419 +156
Misses 116 116 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
1 task
Relm-Arrowny
marked this pull request as ready for review
July 20, 2026 15:19
oliwenmandiamond
requested changes
Jul 21, 2026
oliwenmandiamond
left a comment
Contributor
There was a problem hiding this comment.
Thanks, looks good but have feedback to improve. As @Villtord mentioned in standup, could we please also make sure to add doc strings to the devices. Thanks!
…-magnetic-controllers
…b.com/DiamondLightSource/dodal into update_id_logic_to_use_standard_movable
* Create UndulatorAccessControl Device * Clean up imports * Add access control as dependency for test * Add doc string and improve set_ and wait func
This reverts commit 20383ba.
Co-authored-by: Raymond Fan <raymond.fan@diamond.ac.uk>
…_ophyd_async_0_21_1
…d-magnetic-controllers
oliwenmandiamond
changed the base branch from
main
to
update_to_ophyd_async_0_21_1
August 18, 2026 09:22
oliwenmandiamond
approved these changes
Aug 18, 2026
oliwenmandiamond
left a comment
Contributor
There was a problem hiding this comment.
LGTM, thanks for doing this
oliwenmandiamond
enabled auto-merge (squash)
August 18, 2026 09:41
oliwenmandiamond
deleted the
2113-i10-1-high-field-magnetic-controllers
branch
August 18, 2026 09:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2113, #2124
Requires: ophyd-async(#1381). #2155
added a new generic temperature_controller:
Added support for the I06-1 SCM Cryocon M32 temperature controller:
Added support for the I10-1 High Field Magnet temperature controllers:
Fixed historical typo in module naming:
Instructions to reviewer on how to test:
Checks for reviewer
dodal connect ${BEAMLINE}