feat(android): user-selectable playback speed and open-in-external-app for media viewer - #2479
Open
MANICX100 wants to merge 1 commit into
Open
feat(android): user-selectable playback speed and open-in-external-app for media viewer#2479MANICX100 wants to merge 1 commit into
MANICX100 wants to merge 1 commit into
Conversation
Videos support user-selectable playback speeds from 1x to 4x in 0.1 increments via a speed selector in the player controls, with a configurable default speed in media settings. All media items gain an open-in-external-app action in the viewer top bar and long-press sheet.
Tlaster
reviewed
Sep 4, 2026
Comment on lines
+267
to
+295
| var playbackSpeedValue by remember(globalAppearance.mediaPlaybackSpeed) { | ||
| mutableFloatStateOf(globalAppearance.mediaPlaybackSpeed) | ||
| } | ||
| SegmentedListItem( | ||
| onClick = {}, | ||
| shapes = ListItemDefaults.item(), | ||
| content = { | ||
| Text(text = stringResource(id = R.string.settings_media_playback_speed)) | ||
| }, | ||
| supportingContent = { | ||
| Column { | ||
| Text(text = stringResource(id = R.string.settings_media_playback_speed_description)) | ||
| Slider( | ||
| value = playbackSpeedValue, | ||
| onValueChange = { | ||
| playbackSpeedValue = (it * 10).roundToInt() / 10f | ||
| }, | ||
| onValueChangeFinished = { | ||
| state.update(AppearanceKeys.MediaPlaybackSpeed, playbackSpeedValue) | ||
| }, | ||
| valueRange = 1f..4f, | ||
| steps = 29, | ||
| ) | ||
| } | ||
| }, | ||
| trailingContent = { | ||
| Text(text = "%.1fx".format(playbackSpeedValue)) | ||
| }, | ||
| ) |
Contributor
There was a problem hiding this comment.
Any reason we need this in setting?
Author
|
The user can set their default playback speed and have it remembered.
4 Sept 2026 07:29:16 Tlaster ***@***.***>:
…
***@***.**** commented on this pull request.
----------------------------------------
In app/src/main/java/dev/dimension/flare/ui/screen/settings/AppearanceMediaScreen.kt[#2479 (comment)]:
> + var playbackSpeedValue by remember(globalAppearance.mediaPlaybackSpeed) {
+ mutableFloatStateOf(globalAppearance.mediaPlaybackSpeed)
+ }
+ SegmentedListItem(
+ onClick = {},
+ shapes = ListItemDefaults.item(),
+ content = {
+ Text(text = stringResource(id = R.string.settings_media_playback_speed))
+ },
+ supportingContent = {
+ Column {
+ Text(text = stringResource(id = R.string.settings_media_playback_speed_description))
+ Slider(
+ value = playbackSpeedValue,
+ onValueChange = {
+ playbackSpeedValue = (it * 10).roundToInt() / 10f
+ },
+ onValueChangeFinished = {
+ state.update(AppearanceKeys.MediaPlaybackSpeed, playbackSpeedValue)
+ },
+ valueRange = 1f..4f,
+ steps = 29,
+ )
+ }
+ },
+ trailingContent = {
+ Text(text = "%.1fx".format(playbackSpeedValue))
+ },
+ )
Any reason we need this in setting?
—
Reply to this email directly, view it on GitHub[#2479?email_source=notifications&email_token=ABIOXSIYAI6DQHF6BBXEIML5NJOLZA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTKMJQHE4DMNZWGI42M4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KYZTPN52GK4S7MNWGSY3L#pullrequestreview-5109867629], or unsubscribe[https://github.com/notifications/unsubscribe-auth/ABIOXSKB4DLXCLGER7SNPWT5NJOLZAVCNFSNUABFKJSXA33TNF2G64TZHM3DMOBSGI3TCNZTHNEXG43VMU5TKMZTHA4DGMBRGE4KC5QC].
You are receiving this because you authored the thread.
[Tracking image][https://github.com/notifications/beacon/ABIOXSP6XGFMXJHNIQQIMVD5NJOLZBFCNFSM6AAAAAC62Y7IZ6WGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTYAAAAACMESMRW2M4TFMFZW63VGMF2XI2DPOI.gif]
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
app.media_playback_speedglobal appearance key (persisted and included in settings export/import) with a slider in Settings > Appearance > Media. The media viewer starts each video at this speed and resets to it when swiping between pages.ACTION_VIEWchooser with the appropriate MIME type.Details
max(2x, selected speed).speed > 1x, so a custom default speed does not pin the UI open.GlobalAppearancefield with a default value, so other platforms are unaffected.Testing
:app:assembleDebugand verified on a physical device (speed selection, default speed applied on open and page change, fast-playback gesture restore, open-in-external-app for images and videos).