Modifications for bringing in PUMAS round3 ccpp'ization - #1600
Modifications for bringing in PUMAS round3 ccpp'ization#1600cacraigucar wants to merge 12 commits into
Conversation
jimmielin
left a comment
jimmielin
left a comment
There was a problem hiding this comment.
I'm not the official reviewer of this PR but I took a look to see what CAM changes were needed and had a couple of questions. Thanks.
Fix TUVx bug; Use CLM50 in FMOZ compset
Update externals to match cesm3_0_beta09
Refactor aerosol surface area densitie
nusbaume
left a comment
nusbaume
left a comment
There was a problem hiding this comment.
Thanks for bringing in the PUMAS updates @cacraigucar! I have a few change requests, mostly related to cleaning up the snapshot calls.
Also, I should note that an alternative to my snapshot requests could be to just get rid of the microp_section snapshot options, especially if we think we won't actually ever use them.
| if ( (trim(cam_take_snapshot_after) == "pumas_tend") .and. & | ||
| (trim(cam_take_snapshot_before) == trim(cam_take_snapshot_after))) then | ||
| call cam_snapshot_ptend_outfld(ptend, lchnk) | ||
| end if |
There was a problem hiding this comment.
I think I would just remove this snapshot call for now, as it is under the subcolumns section and it is unclear to me if it would even work properly as-is.
| fxtag = eed0685 | ||
| fxrequired = AlwaysRequired | ||
| fxDONOTUSEurl = https://github.com/ESCOMP/atmospheric_physics | ||
| fxDONOTUSEurl = https://github.com/nusbaume/atmospheric_physics |
There was a problem hiding this comment.
Just a reminder to update this all to ESCOMP/atmospheric_physics once the associated PR has been merged. Thanks!
nusbaume
left a comment
nusbaume
left a comment
There was a problem hiding this comment.
Thanks for implementing my request @cacraigucar! Everything looks great to me now.
3 participants
Minor modifications required for bringing in PUMAS round3 ccpp'ization
The user_nl_cam for generating snapshots
cam_snapshot_before_num=6
cam_snapshot_after_num=7
cam_take_snapshot_before='pumas_tend'
cam_take_snapshot_after='pumas_tend'
nhtfrq = 0,0,0,0,0,1,1
ndens = 2,2,2,2,2,1,1
cld_macmic_num_steps = 1