Persist QR scan warning past permission prompt - #6194
Open
j0ntz wants to merge 1 commit into
Open
Conversation
Contributor
Author
j0ntz
force-pushed
the
jon/scan-modal-warning-persist
branch
from
September 3, 2026 23:18
8069b73 to
9c81aa6
Compare
j0ntz
marked this pull request as ready for review
September 3, 2026 23:18
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.







CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
none
Requirements
If you have made any visual changes to the GUI. Make sure you have:
Description
Asana: https://app.asana.com/0/1215088146871429/1217260776591432
ScanModalchose between the scam warning and the camera scanner purely on thecamera permission status, and it fired the permission request the instant the
modal mounted. On a first camera use that produced the reported bug: the warning
rendered, the OS prompt landed on top of it before it could be read, and granting
the permission flipped the render branch, so the warning vanished as the scanner
opened. The warning was only readable when permission was denied, which is
backwards.
The scam warning is now the gate. It stays on screen until the user taps
"Got it!", whichever way the permission prompt was answered, and the permission
request is delayed a beat so the warning is painted before the system prompt
covers it.
isCameraAllowed && isWarningAcknowledgedinsteadof the permission status alone.
"Got it!" once allowed, "Open Settings" (with the existing enable-camera
guidance) when denied or blocked.
Covers all three entry points (Side Menu Scan QR, Send Scan, WalletConnect New
Connection); they all render this one component.
Note
Low Risk
Localized QR scan UX change with no auth, payment, or data-handling impact; behavior is gated in a single modal component.
Overview
ScanModalno longer switches straight to the camera when permission is granted. The financial scamAlertCardUi4stays visible until the user taps Got it!, and the live scanner only opens whenisCameraAllowed && isWarningAcknowledged.Camera permission is requested 750ms after mount so the warning renders before the OS prompt. The footer uses Got it! (disabled until the permission flow finishes; enabled once camera access is allowed) or Open Settings with the existing denied copy when access is blocked.
CHANGELOGdocuments the fix;eslint.config.mjsdrops a legacy override entry for this modal.Reviewed by Cursor Bugbot for commit 9c81aa6. Bugbot is set up for automated code reviews on this repo. Configure here.