Skip to content

fix: neutralize bidi and control chars in action logs - #763

Merged
EndBug merged 2 commits into
mainfrom
cursor/fix-log-bidi-spoofing
Aug 8, 2026
Merged

fix: neutralize bidi and control chars in action logs#763
EndBug merged 2 commits into
mainfrom
cursor/fix-log-bidi-spoofing

Conversation

@EndBug

@EndBug EndBug commented Aug 8, 2026

Copy link
Copy Markdown
Owner

Summary

  • Sanitize strings logged through log() so Unicode bidi/isolate controls and C0/C1 characters render as visible \uXXXX escapes instead of spoofing CI log display.
  • Apply the same neutralization to conflicted file paths in the pull conflict error.
  • Add unit coverage and rebuild the bundled lib/ artifact.

Test plan

  • npm test passes (includes new neutralizeLogString / neutralizeForLog cases)
  • Confirm a path containing U+202E logs as \u202e rather than reversing surrounding text
  • Confirm normal ASCII filenames are unchanged in logs

Made with Cursor

Summary by CodeRabbit

  • Bug Fixes

    • Improved log safety by escaping control, bidirectional, and Unicode isolation characters.
    • Sanitized error messages, file paths, object data, and nested values before displaying logs.
    • Pull-conflict messages now display file paths safely without misleading formatting.
    • Circular references in logged data are handled safely.
  • Tests

    • Added coverage for log sanitization of filenames, errors, control characters, nested data, and circular references.

Prevent Trojan Source-style filename spoofing when git status paths are printed via log(), and sanitize conflicted paths in pull errors.

Co-authored-by: Cursor <cursoragent@cursor.com>
@coderabbitai

coderabbitai Bot commented Aug 8, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: fffd51af-4b38-4da6-ba1a-c4656a05a5b0

📥 Commits

Reviewing files that changed from the base of the PR and between ab6e718 and 51a7046.

📒 Files selected for processing (3)
  • lib/index.js
  • src/util.ts
  • test/util.test.ts
🚧 Files skipped from review as they are similar to previous changes (2)
  • test/util.test.ts
  • src/util.ts

📝 Walkthrough

Walkthrough

The change adds utilities that neutralize unsafe log characters, recursively sanitizes logged values and errors, and applies path sanitization to pull-conflict messages. Tests cover strings, objects, errors, circular references, and primitive values.

Changes

Log Safety

Layer / File(s) Summary
Log sanitization utilities and coverage
src/util.ts, test/util.test.ts
neutralizeLogString escapes control, bidirectional-format, and Unicode isolation characters. neutralizeForLog recursively sanitizes strings, object keys, arrays, objects, Error fields, and circular references. log now emits sanitized values. Tests cover the new behavior.
Conflict error path sanitization
src/main.ts
Conflict file paths are sanitized before they are included in the thrown error message.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Sequence Diagram(s)

sequenceDiagram
  participant Caller
  participant log
  participant neutralizeForLog
  participant core_error
  Caller->>log: log(data or error)
  log->>neutralizeForLog: sanitize value
  neutralizeForLog-->>log: return sanitized value
  log->>core_error: write sanitized output
Loading
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: neutralizing bidi and control characters in action logs.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch cursor/fix-log-bidi-spoofing

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@EndBug
EndBug marked this pull request as ready for review August 8, 2026 22:44

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/util.ts`:
- Around line 75-85: Update neutralizeForLog to track visited arrays and objects
during recursive sanitization, using a WeakMap or equivalent context passed
through recursion. When a reference is encountered again, return a sanitized
circular-reference marker instead of recursing, while preserving existing array
and object sanitization for non-circular values so log() can complete.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 6da7c15b-c91a-474a-9842-eccffa2df9dd

📥 Commits

Reviewing files that changed from the base of the PR and between 68ec86a and ab6e718.

📒 Files selected for processing (4)
  • lib/index.js
  • src/main.ts
  • src/util.ts
  • test/util.test.ts

Comment thread src/util.ts
Track visited arrays/objects with a WeakSet so log() returns a marker instead of overflowing on cyclic values.

Co-authored-by: Cursor <cursoragent@cursor.com>
@EndBug
EndBug merged commit 06e788f into main Aug 8, 2026
11 checks passed
@EndBug
EndBug deleted the cursor/fix-log-bidi-spoofing branch August 8, 2026 22:51
kodiakhq Bot pushed a commit to pdylanross/fatigue that referenced this pull request Aug 12, 2026
Bumps EndBug/add-and-commit from 10 to 11.

Release notes
Sourced from EndBug/add-and-commit's releases.

v11.0.0
What's Changed

chore(deps): bump picomatch by @​dependabot[bot] in EndBug/add-and-commit#724
chore(deps-dev): bump handlebars from 4.7.8 to 4.7.9 by @​dependabot[bot] in EndBug/add-and-commit#725
chore(deps): bump lodash from 4.17.23 to 4.18.1 by @​dependabot[bot] in EndBug/add-and-commit#728
chore(deps-dev): bump ts-jest from 29.4.6 to 29.4.9 by @​dependabot[bot] in EndBug/add-and-commit#727
chore(deps): bump @​actions/github from 9.0.0 to 9.1.0 by @​dependabot[bot] in EndBug/add-and-commit#729
chore(deps): bump @​actions/github from 9.1.0 to 9.1.1 by @​dependabot[bot] in EndBug/add-and-commit#732
chore(deps): bump @​actions/core from 3.0.0 to 3.0.1 by @​dependabot[bot] in EndBug/add-and-commit#733
ci(deps): bump actions/dependency-review-action from 4 to 5 by @​dependabot[bot] in EndBug/add-and-commit#734
chore(deps-dev): bump ts-jest from 29.4.9 to 29.4.11 by @​dependabot[bot] in EndBug/add-and-commit#736
chore(deps-dev): bump jest from 30.3.0 to 30.4.2 by @​dependabot[bot] in EndBug/add-and-commit#735
chore(deps-dev): bump eslint-plugin-prettier from 5.5.5 to 5.5.6 by @​dependabot[bot] in EndBug/add-and-commit#738
chore(deps): bump js-yaml from 4.1.1 to 4.2.0 by @​dependabot[bot] in EndBug/add-and-commit#739
ci(deps): bump actions/checkout from 6 to 7 by @​dependabot[bot] in EndBug/add-and-commit#741
chore(deps): bump undici from 6.24.1 to 6.27.0 by @​dependabot[bot] in EndBug/add-and-commit#744
ci(deps): bump actions/setup-node from 6 to 7 by @​dependabot[bot] in EndBug/add-and-commit#749
chore(deps-dev): bump @​vercel/ncc from 0.38.4 to 0.44.1 by @​dependabot[bot] in EndBug/add-and-commit#746
chore(deps): bump js-yaml from 4.2.0 to 5.2.1 by @​dependabot[bot] in EndBug/add-and-commit#747
chore(deps-dev): bump ts-jest from 29.4.11 to 29.4.12 by @​dependabot[bot] in EndBug/add-and-commit#750
chore(deps): bump js-yaml from 5.2.1 to 5.2.2 by @​dependabot[bot] in EndBug/add-and-commit#751
chore(deps): bump undici from 6.27.0 to 6.28.0 by @​dependabot[bot] in EndBug/add-and-commit#753
fix: reject remote-helper git flags that enable RCE by @​EndBug in EndBug/add-and-commit#754
fix: prevent git option injection via new_branch by @​EndBug in EndBug/add-and-commit#755
fix: verify committed lib/ matches source in CI by @​EndBug in EndBug/add-and-commit#756
fix: stop logging full git config (credential leak) by @​EndBug in EndBug/add-and-commit#758
fix: reject -F/--file git args that can exfiltrate runner files by @​EndBug in EndBug/add-and-commit#759
fix: reject unmatched quotes in matchGitArgs to prevent flag injection by @​EndBug in EndBug/add-and-commit#760
fix: refuse unexpected gitlinks staged by git add by @​EndBug in EndBug/add-and-commit#761
fix: do not report committed=true for empty commit SHA by @​EndBug in EndBug/add-and-commit#757
ci: pin actions-tagger and restrict release workflow permissions by @​EndBug in EndBug/add-and-commit#762
fix: neutralize bidi and control chars in action logs by @​EndBug in EndBug/add-and-commit#763

Full Changelog: EndBug/add-and-commit@v10.0.0...v11.0.0



Commits

645ecc0 11.0.0
06e788f fix: neutralize bidi and control chars in action logs (#763)
68ec86a ci: pin actions-tagger and restrict release workflow permissions (#762)
f1bb0cc fix: do not report committed=true for empty commit SHA (#757)
ebc24bf fix: refuse unexpected gitlinks staged by git add (#761)
75038f8 fix: reject unmatched quotes in matchGitArgs to prevent flag injection (#760)
d07c930 fix: reject -F/--file git args that can exfiltrate runner files (#759)
0971289 fix: stop logging full git config (credential leak) (#758)
c38a33b fix: verify committed lib/ matches source in CI (#756)
b4a0134 fix: prevent git option injection via new_branch (#755)
Additional commits viewable in compare view




Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

@dependabot rebase will rebase this PR
@dependabot recreate will recreate this PR, overwriting any edits that have been made to it
@dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
@dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant