Add DOS, featurizer, FlashMD, and ShiftML regression cases - #3
Open
EricBoittier wants to merge 1 commit into
Open
EricBoittier wants to merge 1 commit into
EricBoittier wants to merge 1 commit into
Conversation
Lock the exports the harness named but did not yet run, and let the engine load the older graphs those models actually ship.
|
I'm working on this right now =) This needs lab-cosmo/flashmd#58 and lab-cosmo/upet#169 first. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Locks the ecosystem exports the regression harness names but does not yet run: PET-MAD-DOS 1.0, the PET-MAD featurizer 1.0.0, FlashMD
pet-omatpes-v2at 16 fs, and ShiftML3 model 1. Each case is one structure and compares the outputs listed inregtests/README.mdto stored.mtsfiles.The engine now attaches inputs a model reads without declaring them through
requested_inputs()(FlashMD momenta), and a case can set"check_consistency": falsewhen an export's declared dtype does not match the tensors it returns (the featurizer).AtomisticModelloads exports from before_model_capabilities_outputs_nameswas stored, which FlashMD 0.1.11 needs.This description was drafted with the help of an LLM.
The four new entries in
models.lockstill haveurl: null.export-models.py --check, and thereforetox -e regtests, fails until those files are uploaded tometatensor/metatomic-regtests. Pytest itself passes when the.ptfiles are inregtests/cache/.Stacked on the harness commit from metatensor#334 (
f45e70d). This PR is on Eric's fork so it can be retargeted ontoLuthaf:ecosystem-regtestwithout pushing to that branch.Contributor (creator of pull-request) checklist
Reviewer checklist