[gui] Only call fetchStatistics if the filters are ready - #5052
Merged
Merged
Conversation
dkrupp
requested changes
Aug 27, 2026
dkrupp
left a comment
dkrupp
left a comment
Member
There was a problem hiding this comment.
I am not so fan of timers, because it can introduce flaky behaviour depending on (browser/machine).
Also the debounce mechanism hides multiple sequential events and selects teh first one randomly. Are the filters already loaded then?
I think a much clearer solution would be to define a 1 callback which is fired once all filter is loaded and the data need to be refetched.
- filter change
- page reload
- tab change
gulyasgergely902
force-pushed
the
fix-report-callbacks
branch
2 times, most recently
from
August 28, 2026 09:33
e06e7e1 to
082bb38
Compare
dkrupp
requested changes
Aug 28, 2026
dkrupp
left a comment
dkrupp
left a comment
Member
There was a problem hiding this comment.
please check my minor comments. otherwise looks good.
gulyasgergely902
force-pushed
the
fix-report-callbacks
branch
2 times, most recently
from
August 28, 2026 12:45
efe2abe to
055ee8f
Compare
This change introduces reasons for report filters to why the emit was invoked. Based on this, it can be filtered when a refresh was actually needed and when not.
gulyasgergely902
force-pushed
the
fix-report-callbacks
branch
from
August 28, 2026 13:37
055ee8f to
1288a75
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change fixes an issue where fetchStatistics were called multiple times even before the reports filters were ready. This made the UI unresponsive at times.