Payment issue for E/App PR#101309

@eVoloshchak

Issue created to compensate the Contributor+ member for their work on #101309
E/E issue linked to the PR - https://www.github.com/Expensify/Expensify/issues/681919.
Contributor+ member who reviewed the PR - @eVoloshchak.

Wait 7 days after the PR is deployed to production before issuing payment in case there are regressions.

@eVoloshchak

@eVoloshchak The PR you reviewed has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]

@mallenexpensify

Triggered auto assignment to @mallenexpensify (Awaiting Payment)

@eVoloshchak

Payment Summary

Reviewer: @eVoloshchak owed $175 via NewDot

BugZero Checklist (@mallenexpensify)

I have confirmed assignees, roles, and Upwork contracts look correct
I have paid out Upwork contracts / manual NewDot requests
[BugZero Assignee] I have created a GH issue for creating/updating the regression test once above steps have been agreed upon

Contributor+ Checklist:

[Contributor] The offending PR and associated issue have been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

Link to the comment on the PR: N/A, new feature
Link to the comment on the Issue:
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

Link to discussion: N/A, new feature
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

Regression Test Proposal

Test:

Sign in as an admin of a workspace connected to QBO with "Export company card expenses as" set to Credit card, with at least one non-reimbursable expense that has a vendor assigned and one without.
Open Expenses, and click Filters. Verify Vendor appears next to Category and Tag.
Open Vendor and verify the workspace's synced vendors and "No vendor" are listed.
Select one vendor and apply. Verify only expenses with that vendor are returned and the filter chip reads "Vendor: ".
Select "No vendor" and verify only expenses without a vendor are returned.
Click the search icon at the top right and type type:expense vendor:. Verify the vendor name is highlighted like the other filter values, then press Enter and verify the same results as step 4.
Save the search and verify the saved search re-applies the vendor filter when opened.
Click the search icon and search type:expense -vendor:. Verify the filter chip reads "-Vendor: " and the expenses with that vendor are excluded.
With that search open, add a Category from Filters. Verify the "-Vendor: " chip stays and the expenses with that vendor are still excluded.
Sign in as a non-admin member of the same workspace and verify Vendor appears in the filter list with the workspace's synced vendors.

Do we agree 👍 or 👎

@eVoloshchak

Deploy Blocker #103145 was identified to be related to this PR.

@eVoloshchak this issue and/or PR mention a deploy blocker or a regression. Before the payment date, post one of the three options in step 20 of the C+ doc: it was a regression, it was not, or you did not review the offending PR. If you don't post, the default is to reduce payment.

Ah my bad it's actually not ready for payment, there is a follow-up PR for fixing that regression

@MelvinBot

@MelvinBot, please add a Skip Payment label

I added the Skip Payment label to this issue.

view run

Please comment and tag me if/when payment is due, thx

@eVoloshchak

@eVoloshchak Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@eVoloshchak

@eVoloshchak Huh... This is 4 days overdue. Who can take care of this?

@eVoloshchak

@eVoloshchak 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

Not overdue, #104351 is still in progress

@eVoloshchak

@eVoloshchak Whoops! This issue is 2 days overdue. Let's get this updated quick!

Navigation Menu

Repository navigation

Payment issue for E/App PR#101309 #103249

Payment Summary

BugZero Checklist (@mallenexpensify)

Contributor+ Checklist:

Regression Test Proposal

Test:

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Payment issue for E/App PR#101309 #103249

Description

Activity

melvin-bot commented on Oct 6, 2026

melvin-bot commented on Oct 12, 2026

melvin-bot commented on Oct 12, 2026

Payment Summary

BugZero Checklist (@mallenexpensify)

eVoloshchak commented on Oct 13, 2026

Contributor+ Checklist:

Regression Test Proposal

Test:

mallenexpensify commented on Oct 15, 2026

eVoloshchak commented on Oct 15, 2026

eVoloshchak commented on Oct 15, 2026

MelvinBot commented on Oct 15, 2026

mallenexpensify commented on Oct 16, 2026

melvin-bot commented on Oct 19, 2026

melvin-bot commented on Oct 21, 2026

melvin-bot commented on Oct 23, 2026

eVoloshchak commented on Oct 26, 2026

melvin-bot commented on Oct 29, 2026

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions