You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$175] Android- Connections - Inconsistent column when rotating to landscape & reopened in landscape #105148
Version Number: 9.5.23-0 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack:#104402 Email or phone of affected tester (no customers):sjodinjoisdjoisjio@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Samsung Galaxy S25 FE / Android 16 App Component: Workspace Settings
Action Performed:
Precondition:
Set device font size to minimum.
Enable unifiedConnections beta.
Launch Expensify app.
Go to workspace settings > Connections.
Rotate device to landscape.
→ Connections page shows 2 columns after rotating to landscape.
Tap app back button.
Reopen Connections.
→ Connections page shows 1 column when reopened.
Expected Result:
Connection page should show consistent column when rotating to landscape (Step 3) and page is opened in landscape mode (Step 5).
Actual Result:
In Step 3, after rotating to landscape, Connections page shows 2 columns.
In Step 5, when reopening Connections page in landscape mode, Connections page shows 1 column.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
I don't have context on this one since I wasn't assigned to the original issues nor PR so I'll unassign myself for now. Let me know if no one else is able to look though.
Confirmed from the code: More features uses the same card style in production (9.5.22-0). That fits your repro and supports demoting this blocker.
More features: on native, each card uses workspaceSectionMoreFeaturesItem plus flexBasis100 with a minimum width of 0, inside a wrapping row (MoreFeatureToggle.tsx:63-65). Those lines are the same in the 9.5.22-0 release.
Known cause: a comment in the styles already says native Yoga caches a percentage flexBasis across rotations. Those onboarding tiles use width to avoid it (styles/index.ts:6031-6033).
One fix covers both pages. Replace flexBasis100 with flexBasisAuto plus w100 in MoreFeatureToggle.tsx, ConnectionCard.tsx, and ExactOnlineWaitlistCard.tsx.
I confirmed this from the code only. This run tests on web, so I couldn't reproduce the rotation on Android.
Thanks @Beamanator, I'll take it. @Krishna2323 MelvinBot's fix above makes sense to me, can you raise a PR with it? It covers More features too, so it should fix @situchan's repro as well.
It replaces flexBasis100 with flexBasisAuto + w100 in MoreFeatureToggle.tsx, ConnectionCard.tsx, and ExactOnlineWaitlistCard.tsx. That fixes both More features and Connections.
Typecheck, lint, spell check, the React Compiler check, and the 3 related Jest suites (48 tests) passed. I couldn't test the UI because my web session failed to load. Please verify the rotation repro on Android before marking the PR ready for review.
Please mark it as "Ready for review" or ask me to do that for you when it is ready for review.
changed the title [-]Android- Connections - Inconsistent column when rotating to landscape & reopened in landscape[/-][+][$175] Android- Connections - Inconsistent column when rotating to landscape & reopened in landscape[/+]on Oct 29, 2026
Activity
applause-bot commentedon Oct 27, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/b37d4c1b5a1e5f3eb1d001d9f6819cbdea4237b879518716a620e045188d6e3a
melvin-bot commentedon Oct 27, 2026
@lakchote recently merged #104402, but they are OOO right now, so I'll auto-assign someone else.
github-actions commentedon Oct 27, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
melvin-bot commentedon Oct 27, 2026
Triggered auto assignment to @francoisl (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Oct 27, 2026
@Beamanator @lakchote @situchan you have been assigned to this deploy blocker because you reviewed the offending PR: #104402
9 remaining items
Beamanator commentedon Oct 27, 2026
@francoisl @lakchote do one of y'all wanna take this? we obviously don't need 3 of us assigned here hehe
francoisl commentedon Oct 27, 2026
I don't have context on this one since I wasn't assigned to the original issues nor PR so I'll unassign myself for now. Let me know if no one else is able to look though.
Beamanator commentedon Oct 27, 2026
@lakchote is the main internal reviewer from #102265 so i may also unassign :D but happy to help look if ya need @lakchote !
MelvinBot commentedon Oct 27, 2026
Confirmed from the code: More features uses the same card style in production (9.5.22-0). That fits your repro and supports demoting this blocker.
workspaceSectionMoreFeaturesItemplusflexBasis100with a minimum width of 0, inside a wrapping row (MoreFeatureToggle.tsx:63-65). Those lines are the same in the9.5.22-0release.flexBasisacross rotations. Those onboarding tiles usewidthto avoid it (styles/index.ts:6031-6033).One fix covers both pages. Replace
flexBasis100withflexBasisAutoplusw100inMoreFeatureToggle.tsx,ConnectionCard.tsx, andExactOnlineWaitlistCard.tsx.I confirmed this from the code only. This run tests on web, so I couldn't reproduce the rotation on Android.
view run
lakchote commentedon Oct 29, 2026
Thanks @Beamanator, I'll take it. @Krishna2323 MelvinBot's fix above makes sense to me, can you raise a PR with it? It covers More features too, so it should fix @situchan's repro as well.
situchan commentedon Oct 29, 2026
@MelvinBot implement this
MelvinBot commentedon Oct 29, 2026
🤖 Draft PR created: Keep stacked workspace cards one per row after device rotation
It replaces
flexBasis100withflexBasisAuto+w100inMoreFeatureToggle.tsx,ConnectionCard.tsx, andExactOnlineWaitlistCard.tsx. That fixes both More features and Connections.Typecheck, lint, spell check, the React Compiler check, and the 3 related Jest suites (48 tests) passed. I couldn't test the UI because my web session failed to load. Please verify the rotation repro on Android before marking the PR ready for review.
Please mark it as "Ready for review" or ask me to do that for you when it is ready for review.
view run · no recording available
[-]Android- Connections - Inconsistent column when rotating to landscape & reopened in landscape[/-][+][$175] Android- Connections - Inconsistent column when rotating to landscape & reopened in landscape[/+]melvin-bot commentedon Oct 29, 2026
Job added to Upwork: https://www.upwork.com/jobs/~022115892985771095358