[thelullabyy]

Explanation of Change

Part 3 of removing the ONYXKEYS.COLLECTION.REPORT dependency from OptionsListUtils. This PR refactors only getAlternateText.

getAlternateText used to call getReportOrDraftReport(option.reportID), which reads the module-level Onyx.connect() reports cache in ReportUtils. It now takes the report through a new required report field on GetAlternateTextConfig. All callers already had that report:

• createOption passes the report it is building the option from
• prepareReportOptionsForDisplay passes option.item, which comes from the same snapshot as the option list
• InSelector passes the reportData it already reads with useOnyx(ONYXKEYS.COLLECTION.REPORT)

Unit tests:

• The existing getAlternateText tests now pass the report explicitly.
• A new report resolution suite covers:
  • a report that is missing from Onyx
  • the passed report winning over a stale Onyx copy with the same ID
  • admin and announce rooms with forcePolicyNamePreview
  • no fallback to Onyx when no report is passed
  • group chat vs DM labels
  • the report being passed through createOptionFromReport and getValidOptions

Fixed Issues

$ #66378
PROPOSAL:

Tests

Precondition:

1. Account A (the tester) has at least one workspace, and is in a room with recent messages, a group chat and a 1:1 DM with account B

Test 1: Chat preview in the Search router

1. As B, send a message in the room shared with A
2. As A, open the Search router (Cmd/Ctrl + K) without typing
3. Verify the room in the recent chats shows the preview as B's name: message
4. As A, send a message in the same room and reopen the Search router
5. Verify the preview now reads You: message

Test 2: Search in: filter

1. Go to Reports > Filters > In
2. Verify the group chat shows Group as its subtitle, rooms show their room subtitle and the DM shows the participant's login
3. Select a few chats, then close and reopen the filter
4. Verify the selected chats are listed at the top with the same subtitles

• Verify that no errors appear in the JS console

Offline tests

Same as tests while offline: previews and subtitles keep rendering from the cached data.

QA Steps

Same

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If the PR adds or modifies the UI:
  • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
  • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
  • I verified all new/changed elements have meaningful accessible names and roles.
  • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-10-18.at.21.46.35.mov

[melvin-bot]

@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[chatgpt-codex-connector]

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-18T14:00:38.246855Z	f527862	Draft marked ready

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

[JmillsExpensify]

No product review required.

[DylanDylann]

Could you add more changes to this PR? Right now, most of it is just new test cases