Skip to content

[No QA] Docs updates for E/A#104249 Document Current view (groups only) export option - #105191

Merged
joekaufmanexpensify merged 1 commit into
mainfrom
claude-docsCurrentViewGroupsOnly
Oct 28, 2026
Merged

joekaufmanexpensify merged 1 commit into
mainfrom
claude-docsCurrentViewGroupsOnly

Conversation

@MelvinBot

Copy link
Copy Markdown
Contributor

Explanation of Change

Help site update for #104249, which adds a new Current view (groups only) option to the Export menu on grouped searches. The option exports only the group rows, without the expenses in each group.

New feature: Current view (groups only).

Article updated: docs/articles/new-expensify/reports-and-expenses/Search-and-Download-Expenses.md, step 6 of "Export grouped expenses".

Previous step:

  1. Select Current view.

New step:

  1. Select Current view, or select Current view (groups only) to export only the group rows without the expenses in each group.

The label matches export.currentViewGroupsOnly in src/languages/en.ts. No new sections or FAQs were added.

@rlinoz, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying @MelvinBot mark this PR as ready for review.

Fixed Issues

$ #104047
PROPOSAL:

Tests

// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.

  • Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

Co-authored-by: Rodrigo Lino da Costa <rlinoz@users.noreply.github.com>
@MelvinBot MelvinBot added the HelpDot Apply this label if the issue relates to ExpensifyHelp label Oct 27, 2026
@MelvinBot
MelvinBot requested a review from a team October 27, 2026 22:17
@rlinoz
rlinoz marked this pull request as ready for review October 28, 2026 11:27
@melvin-bot

melvin-bot Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Product reviewer checklist:

  • I have verified the accuracy of the article
    • The article is within a hub that makes sense, and the navigation is correct
    • All processes, screenshots, and examples align with current product behavior.
    • All links within the doc have been verified for correct destination and functionality.
  • I have verified the readability of the article
    • The article's language is clear, concise, and free of jargon.
    • The grammar, spelling, and punctuation are correct.
    • The article contains at least one image, or that an image is not necessary
  • I have verified the formatting of the article
    • The article has consistent formatting (headings, bullet points, etc.) with other HelpDot articles and that aligns with the HelpDot formatting standards.
    • The article has proper text spacing and breaks for readability.
  • I have verified the article has the appropriate tone and style
    • The article's tone is professional, friendly, and suitable for the target audience.
    • The article's tone, terminology, and voice are consistent throughout.
  • I have verified the overall quality of the article
    • The article is not missing any information, nor does it contain redundant information.
    • The article fully addresses user needs.
  • I have verified that all requested improvements have been addressed

For more detailed instructions on completing this checklist, see How do I review a HelpDot PR?

cc @joekaufmanexpensify

@melvin-bot
melvin-bot Bot requested review from joekaufmanexpensify and removed request for a team October 28, 2026 11:28
@melvin-bot

melvin-bot Bot commented Oct 28, 2026

Copy link
Copy Markdown

@joekaufmanexpensify Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-28T11:42:14.984451Z c4d00fe Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This PR makes a single-line change to Search-and-Download-Expenses.md, updating step 6 of the "Export grouped expenses" procedure to document the new Current view (groups only) export option. The change is tightly scoped, accurate, and matches the export.currentViewGroupsOnly label in src/languages/en.ts.

Scores Summary

  • Readability: 9/10 - The step is clear, action-oriented, and explains what the new option does in plain language. The combined sentence is slightly long but remains easy to scan.
  • AI Readiness: 9/10 - Uses the full, UI-exact feature name Current view (groups only), which is highly retrievable. No metadata or heading changes were introduced, so existing structure is unaffected.
  • Style Compliance: 10/10 - Uses select (not click/tap), bolds the exact UI label with correct sentence case, and keeps generic terms (group rows, expenses) lowercase per the naming conventions.

Key Findings

  • The new option name matches the UI label exactly and is correctly bolded.
  • The added clarifying phrase ("to export only the group rows without the expenses in each group") is concise and genuinely helpful.
  • The change is additive and preserves the existing sequential step formatting.
  • Note (pre-existing, out of scope): earlier steps in this procedure use Click rather than select, which conflicts with the conventions. Not introduced by this PR, so not scored against it, but worth a future cleanup.

Recommendations

  • No changes required. The diff is compliant and ready.
  • Optional future follow-up: align the surrounding steps (2 and 3) that still use Click with the select convention.

Files Reviewed

  • Search-and-Download-Expenses.md - Approved. Single-line step update; compliant with governance.

Note: The change is a single line; no additional inline comments were necessary.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c4d00fee88

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

4. Check the box next to the groups you want to export, or use the top checkbox to select all.
5. On the selection bar, choose **Export**.
6. Select **Current view**.
6. Select **Current view**, or select **Current view (groups only)** to export only the group rows without the expenses in each group.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Separate the output descriptions for the two export modes

When a user selects Current view (groups only), the unqualified “In the exported file” section immediately below still says that expenses are listed beneath every group and that mixed selections include expense rows. This contradicts the newly documented groups-only behavior and can make a correct summary-only export appear broken; clarify that the existing bullets apply only to Current view, and separately describe the groups-only output.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is clear enough, but let me know if we should change.

@stephanieelliott stephanieelliott changed the title Docs updates for E/A#104249 Document Current view (groups only) export option [No QA] Docs updates for E/A#104249 Document Current view (groups only) export option Oct 28, 2026
@joekaufmanexpensify
joekaufmanexpensify merged commit 5e3aa40 into main Oct 28, 2026
29 of 34 checks passed
@joekaufmanexpensify
joekaufmanexpensify deleted the claude-docsCurrentViewGroupsOnly branch October 28, 2026 21:33
@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/joekaufmanexpensify in version: 9.5.25-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.5.25-2 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants