Repository navigation
[No QA] Docs updates for E/A#104249 Document Current view (groups only) export option - #105191
Conversation
Co-authored-by: Rodrigo Lino da Costa <rlinoz@users.noreply.github.com>
Product reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR? |
|
@joekaufmanexpensify Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
HelpDot Documentation ReviewOverall AssessmentThis PR makes a single-line change to Search-and-Download-Expenses.md, updating step 6 of the "Export grouped expenses" procedure to document the new Current view (groups only) export option. The change is tightly scoped, accurate, and matches the export.currentViewGroupsOnly label in src/languages/en.ts. Scores Summary
Key Findings
Recommendations
Files Reviewed
Note: The change is a single line; no additional inline comments were necessary. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c4d00fee88
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| 4. Check the box next to the groups you want to export, or use the top checkbox to select all. | ||
| 5. On the selection bar, choose **Export**. | ||
| 6. Select **Current view**. | ||
| 6. Select **Current view**, or select **Current view (groups only)** to export only the group rows without the expenses in each group. |
There was a problem hiding this comment.
Separate the output descriptions for the two export modes
When a user selects Current view (groups only), the unqualified “In the exported file” section immediately below still says that expenses are listed beneath every group and that mixed selections include expense rows. This contradicts the newly documented groups-only behavior and can make a correct summary-only export appear broken; clarify that the existing bullets apply only to Current view, and separately describe the groups-only output.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
I think this is clear enough, but let me know if we should change.
|
🚀 Deployed to staging by https://github.com/joekaufmanexpensify in version: 9.5.25-0 🚀
|
|
🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.5.25-2 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Help site update for #104249, which adds a new Current view (groups only) option to the Export menu on grouped searches. The option exports only the group rows, without the expenses in each group.
New feature: Current view (groups only).
Article updated:
docs/articles/new-expensify/reports-and-expenses/Search-and-Download-Expenses.md, step 6 of "Export grouped expenses".Previous step:
New step:
The label matches
export.currentViewGroupsOnlyinsrc/languages/en.ts. No new sections or FAQs were added.@rlinoz, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.Fixed Issues
$ #104047
PROPOSAL:
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.
Offline tests
QA Steps
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari