Repository navigation
[No QA] Docs updates for E/A#104668 Update Paid by filter position for expense reports - #105193
Conversation
Co-authored-by: Krishna <Krishna2323@users.noreply.github.com>
Product reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR? |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
HelpDot Documentation ReviewOverall AssessmentThis PR makes a single-line factual correction to Scores Summary
Key Findings
Recommendations
Files Reviewed
Note: This change is a one-line edit, so no additional inline comments were necessary. |
Explanation of Change
Reorganize the Search
Filterspage into clearer sections and add a filter search moved Paid by on the Expense Report type so it now sits directly below Paid and above Paid status. This made one sentence in Using Reports in New Expensify wrong.Incorrect sentence:
Updated sentence:
I checked the new order in the live web UI:
@Krishna2323, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.Fixed Issues
$ #104330
PROPOSAL:
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.
Offline tests
QA Steps
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari