Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/workflows/homeboy-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ jobs:
# v2.14.2 keeps raw candidate evidence neutral; this reconciled Test gate
# alone decides whether the full-suite candidate regresses from main.
commands: 'review test'
expected-commands: 'review test'
# PR CI is the authoritative complete MySQL suite. Repository defaults
# remain Docker-free SQLite for local and release-preflight parity.
args: '--setting database_type=mysql --setting wp_codebox_phpunit_config=/wordpress/wp-content/plugins/data-machine/phpunit.xml.dist'
Expand Down
6 changes: 1 addition & 5 deletions .github/workflows/homeboy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,5 @@ jobs:
if: ${{ github.event_name != 'push' }}
uses: Extra-Chill/homeboy-action/.github/workflows/ci.yml@v2
with:
# Autofix on PRs is expressed by adding `refactor lint` to the commands
# list — ci.yml@v2 has no `autofix`/`autofix-commands` inputs, and passing
# undeclared inputs to a reusable workflow is a hard startup_failure.
commands: ${{ github.event_name == 'pull_request' && 'review audit,review lint,refactor lint' || 'review audit,review lint' }}
expected-commands: 'review audit,review lint'
commands: review lint
secrets: inherit
39 changes: 0 additions & 39 deletions homeboy.json
Original file line number Diff line number Diff line change
Expand Up @@ -1250,45 +1250,6 @@
]
}
},
"transforms": {
"drop_wp_ability_dead_guards": {
"description": "Drop dead class_exists('WP_Ability') and class_exists('WP_Abilities_Registry') guards. Plugin header requires WP 7.0 where both classes ship in core, so every guard on these symbols is unreachable. Ref: https://github.com/Extra-Chill/data-machine/issues/XXXX",
"rules": [
{
"context": "file",
"description": "Remove standalone if ( ! class_exists( 'WP_Ability' ) ) { return; } blocks.",
"files": "inc/Abilities/**/*.php",
"find": "(?s)\n\t\tif \\( ! class_exists\\( ?'WP_Ability' ?\\) \\) \\{\n\t\t\treturn;\n\t\t\\}\n",
"id": "simple_guard",
"replace": ""
},
{
"context": "file",
"description": "Drop the WP_Ability half of 'if ( ! class_exists( WP_Ability ) || self::$registered ) { return; }' guards.",
"files": "inc/Abilities/**/*.php",
"find": "(?s)if \\( ! class_exists\\( 'WP_Ability' \\) \\|\\| self::\\$registered \\) \\{\n\t+return;\n\t+\\}",
"id": "combined_guard_registered",
"replace": "if ( self::$$registered ) {\n\t\t\treturn;\n\t\t}"
},
{
"context": "line",
"description": "Replace '(class_exists(WP_Abilities_Registry) ? WP_Abilities_Registry::get_instance() : null)' with a direct call — the ternary is unreachable.",
"files": "inc/**/*.php",
"find": "class_exists\\( 'WP_Abilities_Registry' \\) \\? \\\\WP_Abilities_Registry::get_instance\\(\\) : null",
"id": "ternary_registry_guard",
"replace": "\\\\WP_Abilities_Registry::get_instance()"
},
{
"context": "file",
"description": "Same as combined_guard_registered but catches the one hit in inc/Engine/ (ResolvePendingActionAbility).",
"files": "inc/Engine/**/*.php",
"find": "(?s)if \\( ! class_exists\\( 'WP_Ability' \\) \\|\\| self::\\$registered \\) \\{\n\t+return;\n\t+\\}",
"id": "combined_guard_registered_engine",
"replace": "if ( self::$$registered ) {\n\t\t\treturn;\n\t\t}"
}
]
}
},
"version_targets": [
{
"file": "data-machine.php",
Expand Down
Loading