Repository navigation
feat(player):Add compact lyrics display inside the album cover - #1029
Open
SteveZMTstudios wants to merge 1 commit into
Open
SteveZMTstudios wants to merge 1 commit into
SteveZMTstudios wants to merge 1 commit into
Conversation
Lyrics no longer have to cover the whole player: with "Fullscreen lyrics" turned off they are drawn inside the album cover area instead, so the artwork stays visible while reading them. * CompactLyricMetrics holds the compact-mode design constants (text size, spacing, horizontal padding, decoration scaling) * LyricPanelController owns both LyricsView instances and is now the single entry point the sheet talks to. The inline view is a second instance living in inline_lyric_frame rather than a reparented one: ConstraintSet cannot move a view between parents, and the sheet itself goes GONE in fullscreen mode, so a single view inside it would be hidden by its own ancestor * LyricsView no longer reaches up into FullBottomSheet to toggle the sheet; the host injects onFullPlayerVisibilityRequest, and the sheet resolves its own fullscreen view from onAttachedToWindow so the lazy lookup stays deferred * the lyric button now uses ic_art_track, it was borrowing ic_collections_bookmark and that glyph reads as "save", not "show lyrics" * inline_lyric_frame added to both layout/ and layout-w600dp-land/ variants
SteveZMTstudios
added a commit
to SteveZMTstudios/Gramophone
that referenced
this pull request
Sep 22, 2026
…tial-lyrics-display feat(player):Add compact lyrics display inside the album cover
Member
|
We are rewriting the app in compose, this PR is no longer applicable against that branch sadly. It would likely need complete rework - I'm very sorry, but I cannot do said rework myself due to time constraint. I'm also not yet sure about the visual design, I think I will need to seek some input from other people first before making a decision. The compose-rewrite branch still needs some time, but once PR #1043 is merged, let me know and I'll think about design. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an opt-in mode that draws the lyrics inside the album cover of the full player instead of over the whole screen, so the artwork stays visible while reading them.
New setting: lyrics settings -> "Fullscreen lyrics" (
lyric_fullscreen, default on = current behaviour). Turning it off switches the full player to the compact / inline presentation.Why a second
LyricsViewinstead of moving oneConstraintSetcan only change constraints within one parent. Moving a view between parents needsremoveView+addView, which drops layout and scroll state.FullBottomSheet, andFullBottomSheetitself is setGONEwhile fullscreen lyrics are shown - a single instance inside the sheet would be hidden by its own ancestor.So
inline_lyric_viewis a second instance ininline_lyric_frame, andLyricPanelControlleris the single place that decides which one is visible and keeps the two in sync.Changes
LyricPanelController.kt(new)CompactLyricMetrics.kt(new)LyricsView.ktisCompactMode; stops reaching up intoFullBottomSheet(the host injectsonFullPlayerVisibilityRequest); compact mode forces zero paddingNewLyricsView.kt,LegacyLyricsAdapter.kt,LyricPaddingDecoration.ktFullBottomSheet.ktbottomSheetFullLyricView.*call now goes through the controllerlayout/,layout-w600dp-land/inline_lyric_frame+inline_lyric_viewic_art_track.xml(new)ic_collections_bookmark- a bookmark glyph on an action that saves nothingsettings_lyric.xmlLayout notes
controls.left - 12dp, so it never enters the play-button column.CompactLyricMetrics.HORIZONTAL_PADDING_DP(16 dp, which scales with the lyric font size).Scope
13 files, all in the lyrics display path plus the lyric button's icon. No build
scripts, no root-level config, no unrelated settings screens.
Screenshots