Reduce regular layered graph construction memory - #234
Open
zayenz wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The regular propagator constructs a layered graph for the sequence and DFA. The existing initializer reserves a state slot for every DFA state at every sequence position, so a sequence of length n and a DFA with k states needs (n + 1)k temporary
Stateobjects even when only a small part of that matrix is reachable.This change constructs the graph from sparse forward frontiers, filters it by backward co-reachability, and allocates persistent state nodes only after the surviving layer sizes are known. State-related construction memory is therefore O(k + S), where S is the number of state nodes in the final layered graph. For an unfolded DFA, S <= k. A looping DFA can still have S = Theta(nk), but construction no longer adds a second dense state matrix.
The persistent
Layer,Support,Edge, andStaterepresentation is unchanged. The existing propagator, advisors, cloning, and copy-time compression continue to use the same graph.The added tests cover cyclic frontiers, acyclic reconvergence, position-specific domain pruning, failed acceptance, Boolean views, merged and unmerged terminal states, state-index boundaries, and randomized differential checks.
Evidence from Release builds with Apple Clang:
Int::Extensional::Regsuite passes.