Skip to content

Fix #2631 Search plugin freezes if some WFS request fails - #2635

Merged
allyoucanmap merged 3 commits into
GeoNode:masterfrom
stefanocudini:issue_2631_fix-wfs-search
Sep 14, 2026
Merged

allyoucanmap merged 3 commits into
GeoNode:masterfrom
stefanocudini:issue_2631_fix-wfs-search

Conversation

@stefanocudini

Copy link
Copy Markdown
Member

@stefanocudini stefanocudini added bug Something isn't working and removed bug Something isn't working labels Sep 3, 2026
@stefanocudini

stefanocudini commented Sep 7, 2026 •

Copy link
Copy Markdown
Member Author

@allyoucanmap
this PR upgrade MS submodule breaks 2 tests:
https://github.com/GeoNode/geonode-mapstore-client/actions/runs/33776955733/job/101692129048?pr=2635
Error: Too many re-renders. React limits the number of renders to prevent an infinite loop.

related to pre-existing very old code:
https://github.com/GeoNode/geonode-mapstore-client/blob/master/geonode_mapstore_client/client/js/hooks/__tests__/useLocalStorage-test.js#L29

Apparently there is no correlation with the changes introduced by the MS updates, which only affect changes to epics search. No changes to the components were made here:
https://github.com/geosolutions-it/MapStore2/pull/12847/changes#diff-a85bdac8a4239c4621fd5d01ebfdce1c699faed2c43fe5c9d526760cd480705f

It seems like a similar issue, but I can't figure out how it was introduced:
geosolutions-it/MapStore2#12753 (comment)

I've tried a few other MS merges before this one, and they're still having the problem.
It seems difficult to find when in MS this one broke.

@allyoucanmap

Copy link
Copy Markdown

@stefanocudini the useLocalStorage and the useLocalStorage-test.js can be removed from this repo, they are not used anymore because they were ported in MapStore with the work related to the homepage catalog

Comment thread geonode_mapstore_client/static/mapstore/ms-translations/data.ca-ES.json Outdated
Comment thread geonode_mapstore_client/static/mapstore/ms-translations/data.de-DE.json Outdated
Comment thread geonode_mapstore_client/static/mapstore/ms-translations/data.en-US.json Outdated
Comment thread geonode_mapstore_client/static/mapstore/ms-translations/data.es-ES.json Outdated
Comment thread geonode_mapstore_client/static/mapstore/ms-translations/data.fr-FR.json Outdated
Comment thread geonode_mapstore_client/static/mapstore/ms-translations/data.it-IT.json Outdated
@stefanocudini

stefanocudini commented Sep 14, 2026 •

Copy link
Copy Markdown
Member Author

@allyoucanmap
allyoucanmap merged commit fde7a79 into GeoNode:master Sep 14, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix Search plugin freezes if some WFS request fails Search plugin freezes if some WFS request fails

2 participants