compute: promote mirror_percent in url map request_mirror_policy to GA - #18388
compute: promote mirror_percent in url map request_mirror_policy to GA#18388eidam wants to merge 1 commit into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
Googlers: For automatic test runs see go/terraform-auto-test-runs. @rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
The `mirrorPercent` field is present in the Compute v1 (GA) RequestMirrorPolicy schema, but the provider gated it to google-beta only in both `google_compute_url_map` and `google_compute_region_url_map`. This removes the `min_version: beta` gating from the four field definitions in each resource (default_route_action, path_matcher default_route_action, path_rule route_action, route_rule route_action) and from their examples, so the field is available in the GA provider. The sample configs drop the google-beta provider bindings accordingly.
1b8670c to
10c9335
Compare
|
Need this too, please 🙏 |
|
@rileykarson This PR has been waiting for review for 3 weekdays. Please take a look! Use the label |
|
@GoogleCloudPlatform/terraform-team @rileykarson This PR has been waiting for review for 1 week. Please take a look! Use the label |
|
I would like this to have this as well. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 10c9335: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportImportant Manual Verification Required (GA-only additions) The following tests are GA-only additions and cannot be run by VCR in Beta mode. Please verify them manually: 🔴 TestAccComputeRegionUrlMap_regionUrlMapDefaultMirrorPercentExample Analytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
Caution Issues requiring attention before PR completion 🔴 Manual Verification Required: New tests were added that are skipped in presubmit tests. See the "Manual Verification Required" section at the top for details. 🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the recording VCR build log or the debug logs folder for detailed results. @eidam, @rileykarson VCR tests complete for 10c9335! |
|
Manual test URLs (these are ACL'ed, just for my own reference): |
|
@GoogleCloudPlatform/terraform-team @rileykarson This PR has been waiting for review for 2 weeks. Please take a look! Use the label |
|
@GoogleCloudPlatform/terraform-team @rileykarson This PR has been waiting for review for 3 weeks. Please take a look! Use the label |
Summary
mirrorPercentinRequestMirrorPolicyis available in the Compute v1 (GA) API, but the provider gates the correspondingmirror_percentfield togoogle-betaonly in bothgoogle_compute_url_mapandgoogle_compute_region_url_map.Evidence it is GA — the v1 discovery document defines it directly on the shared
RequestMirrorPolicyschema (referenced byHttpRouteAction, used by both global and regional URL maps):REST reference: https://cloud.google.com/compute/docs/reference/rest/v1/urlMaps
The field was originally added as beta-only in #13974 (global) and #14493 (regional); this promotes it to GA.
Changes
min_version: betafrom all fourmirrorPercentfield definitions in each ofUrlMap.yamlandRegionUrlMap.yaml(default_route_action, path-matcherdefault_route_action, path-ruleroute_action, route-ruleroute_action).min_version: 'beta'from the corresponding*_mirror_percentexamples.google-betaprovider bindings from those example configs so they run against the GA provider. All resources used are GA.Other unrelated beta gating in these files is left untouched.
Release Note
🤖 Generated with Claude Code