Skip to content

compute: promote mirror_percent in url map request_mirror_policy to GA - #18388

Open
eidam wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
eidam:promote-urlmap-mirror-percent-ga
Open

compute: promote mirror_percent in url map request_mirror_policy to GA#18388
eidam wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
eidam:promote-urlmap-mirror-percent-ga

Conversation

@eidam

@eidam eidam commented Jul 24, 2026

Copy link
Copy Markdown

Summary

mirrorPercent in RequestMirrorPolicy is available in the Compute v1 (GA) API, but the provider gates the corresponding mirror_percent field to google-beta only in both google_compute_url_map and google_compute_region_url_map.

Evidence it is GA — the v1 discovery document defines it directly on the shared RequestMirrorPolicy schema (referenced by HttpRouteAction, used by both global and regional URL maps):

// https://www.googleapis.com/discovery/v1/apis/compute/v1/rest
"RequestMirrorPolicy": {
  "properties": {
    "mirrorPercent": { "type": "number", "format": "double", "description": "The percentage of requests to be mirrored to `backend_service`." },
    "backendService": { "type": "string" }
  }
}

REST reference: https://cloud.google.com/compute/docs/reference/rest/v1/urlMaps

The field was originally added as beta-only in #13974 (global) and #14493 (regional); this promotes it to GA.

Changes

  • Remove min_version: beta from all four mirrorPercent field definitions in each of UrlMap.yaml and RegionUrlMap.yaml (default_route_action, path-matcher default_route_action, path-rule route_action, route-rule route_action).
  • Remove min_version: 'beta' from the corresponding *_mirror_percent examples.
  • Drop the google-beta provider bindings from those example configs so they run against the GA provider. All resources used are GA.

Other unrelated beta gating in these files is left untouched.

Release Note

compute: promoted `mirror_percent` in `request_mirror_policy` to GA for `google_compute_url_map` and `google_compute_region_url_map`

🤖 Generated with Claude Code

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Jul 24, 2026
@google-cla

google-cla Bot commented Jul 24, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@github-actions
github-actions Bot requested a review from rileykarson July 24, 2026 14:20
@github-actions

Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

The `mirrorPercent` field is present in the Compute v1 (GA) RequestMirrorPolicy schema, but the provider gated it to google-beta only in both `google_compute_url_map` and `google_compute_region_url_map`.

This removes the `min_version: beta` gating from the four field definitions in each resource (default_route_action, path_matcher default_route_action, path_rule route_action, route_rule route_action) and from their examples, so the field is available in the GA provider. The sample configs drop the google-beta provider bindings accordingly.
@eidam
eidam force-pushed the promote-urlmap-mirror-percent-ga branch from 1b8670c to 10c9335 Compare July 24, 2026 14:23
@ollym

ollym commented Jul 24, 2026

Copy link
Copy Markdown

Need this too, please 🙏

@github-actions

Copy link
Copy Markdown

@rileykarson This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

@github-actions

Copy link
Copy Markdown

@GoogleCloudPlatform/terraform-team @rileykarson This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

@xprazak2

xprazak2 commented Aug 3, 2026

Copy link
Copy Markdown

I would like this to have this as well.

@modular-magician modular-magician added service/compute-l7-load-balancer and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Aug 5, 2026
@modular-magician

modular-magician commented Aug 5, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 10c9335:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 8 files changed, 974 insertions(+), 40 deletions(-)
google-beta provider View Diff 4 files changed, 16 insertions(+), 80 deletions(-)
terraform-google-conversion View Diff 8 files changed, 219 insertions(+)
Open in Cloud Shell View Diff 32 files changed, 1232 insertions(+)

Test report

Important

Manual Verification Required (GA-only additions)

The following tests are GA-only additions and cannot be run by VCR in Beta mode. Please verify them manually:

🔴 TestAccComputeRegionUrlMap_regionUrlMapDefaultMirrorPercentExample
🔴 TestAccComputeRegionUrlMap_regionUrlMapPathMatcherDefaultMirrorPercentExample
🔴 TestAccComputeRegionUrlMap_regionUrlMapPathRuleMirrorPercentExample
🔴 TestAccComputeRegionUrlMap_regionUrlMapRouteRuleMirrorPercentExample
🔴 TestAccComputeUrlMap_urlMapDefaultMirrorPercentExample
🔴 TestAccComputeUrlMap_urlMapPathMatcherDefaultMirrorPercentExample
🔴 TestAccComputeUrlMap_urlMapPathRuleMirrorPercentExample
🔴 TestAccComputeUrlMap_urlMapRouteRuleMirrorPercentExample

Analytics

Total Tests Passed Skipped Affected
1555 1458 95 2
Affected Service Packages
  • compute

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccComputeInstanceFromMachineImage_diffProject
  • TestAccComputeSecurityPolicy_withPreconfiguredWafConfig

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
❌ Error · Log - TestAccComputeInstanceFromMachineImage_diffProject
❌ Error · Log - TestAccComputeSecurityPolicy_withPreconfiguredWafConfig

Caution

Issues requiring attention before PR completion

🔴 Manual Verification Required: New tests were added that are skipped in presubmit tests. See the "Manual Verification Required" section at the top for details.

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@eidam, @rileykarson VCR tests complete for 10c9335!

@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown

@GoogleCloudPlatform/terraform-team @rileykarson This PR has been waiting for review for 2 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

@github-actions

Copy link
Copy Markdown

@GoogleCloudPlatform/terraform-team @rileykarson This PR has been waiting for review for 3 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants