feat: allow objects in GE data connector params

[gwendal-lecren]

This PR allows passing any json as string in the params attribute of google_discovery_engine_data_connector resource.
Fixes hashicorp/terraform-provider-google#28484

discoveryengine: update `params` arguments in `google_discovery_engine_data_connector` as string

[github-actions]

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@malhotrasagar2212, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 2aec183:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository	Diff Link	Changes
google provider	View Diff	5 files changed, 55 insertions(+), 26 deletions(-)
google-beta provider	View Diff	5 files changed, 55 insertions(+), 26 deletions(-)
terraform-google-conversion	View Diff	1 file changed, 7 insertions(+), 6 deletions(-)
Open in Cloud Shell	View Diff	2 files changed, 4 insertions(+), 4 deletions(-)

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

• Field params changed from TypeMap to TypeString on google_discovery_engine_data_connector - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

Test report

Analytics

Total Tests	Passed	Skipped	Affected
53	48	4	1

Affected Service Packages

• discoveryengine

Learn how VCR tests work

---

Step 1: Replaying Mode

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests

• TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample

View the replaying VCR build log

---

Step 2: Recording Mode

Recording Mode	Replaying Rerun	Test Name
❌ Error · Log	-	TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@gwendal-lecren, @malhotrasagar2212 VCR tests complete for 2aec183!

[github-actions]

@malhotrasagar2212 This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[github-actions]

@GoogleCloudPlatform/terraform-team @malhotrasagar2212 This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

[gwendal-lecren]

Hello @malhotrasagar2212 - Could you please help me debugging the issue raised during the acceptance tests? It seems I don't have access the logs :/ Thanks

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 4051ca9:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository	Diff Link	Changes
google provider	View Diff	5 files changed, 55 insertions(+), 26 deletions(-)
google-beta provider	View Diff	5 files changed, 55 insertions(+), 26 deletions(-)
terraform-google-conversion	View Diff	1 file changed, 7 insertions(+), 6 deletions(-)
Open in Cloud Shell	View Diff	2 files changed, 4 insertions(+), 4 deletions(-)

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

• Field params changed from TypeMap to TypeString on google_discovery_engine_data_connector - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

Test report

Analytics

Total Tests	Passed	Skipped	Affected
53	48	4	1

Affected Service Packages

• discoveryengine

Learn how VCR tests work

---

Step 1: Replaying Mode

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests

• TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample

View the replaying VCR build log

---

Step 2: Recording Mode

Recording Mode	Replaying Rerun	Test Name
❌ Error · Log	-	TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@gwendal-lecren, @malhotrasagar2212 VCR tests complete for 4051ca9!

[gwendal-lecren]

Hello @malhotrasagar2212 hope you're doing well. It seems the test issue might actually not be related to this PR: hashicorp/terraform-provider-google#23515
Could it be possible to have a first review? Thanks a lot!

[github-actions]

@GoogleCloudPlatform/terraform-team @malhotrasagar2212 This PR has been waiting for review for 2 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

[malhotrasagar2212]

Changing params from keyValuePairs/Typemap to stings is a breaking change. The state upgrader only migrates stored state; existing HCL using params={...} will no longer validate after a provider upgrade. Could we preserve the existing field and introduce a separate JSON-string/structured field ,or move this type replacement through the major-release?

[gwendal-lecren]

Do we have any idea when the next major release is scheduled? If we move this change to the major-release, is there anything to change in this PR? Not so familiar with terraform contribution, any guidance would be highly appreciated! Thanks 👍