iap: remove deprecated google_iap_brand and google_iap_client - #18679
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
|
Test failures should all be unrelated |
|
@modular-magician reassign-reviewer |
|
Googlers: For automatic test runs see go/terraform-auto-test-runs. @rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
6c0fd64 to
35176f9
Compare
This comment was marked as outdated.
This comment was marked as outdated.
35176f9 to
4c925e6
Compare
This comment was marked as outdated.
This comment was marked as outdated.
4c925e6 to
7f2cbbf
Compare
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 7f2cbbf: Diff reportYour PR generated the following diffs in downstream repositories:
Breaking Change(s) DetectedThe following breaking change(s) were detected within your pull request.
If you believe this detection to be incorrect please raise the concern with your reviewer. Errors
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 82 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
Caution Issues requiring attention before PR completion 🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details. 🔴 Replaying Rerun Failed: Some tests failed due to non-determinism when VCR replayed the response. See the table above for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the recording VCR build log or the debug logs folder for detailed results. |
e1e7b5c
into
GoogleCloudPlatform:FEATURE-BRANCH-major-release-8.0.0
Removes the deprecated
google_iap_brandandgoogle_iap_clientresources andgoogle_iap_clientdata source for the 8.0.0 major release following the permanent shutdown of the Google Cloud IAP OAuth Admin APIs.Fixes hashicorp/terraform-provider-google#23040