Skip to content

iap: remove deprecated google_iap_brand and google_iap_client - #18679

Merged
c2thorn merged 1 commit into
GoogleCloudPlatform:FEATURE-BRANCH-major-release-8.0.0from
c2thorn:remove-iap-brand-client
Aug 19, 2026
Merged

iap: remove deprecated google_iap_brand and google_iap_client#18679
c2thorn merged 1 commit into
GoogleCloudPlatform:FEATURE-BRANCH-major-release-8.0.0from
c2thorn:remove-iap-brand-client

Conversation

@c2thorn

@c2thorn c2thorn commented Aug 17, 2026

Copy link
Copy Markdown
Member

Removes the deprecated google_iap_brand and google_iap_client resources and google_iap_client data source for the 8.0.0 major release following the permanent shutdown of the Google Cloud IAP OAuth Admin APIs.

Fixes hashicorp/terraform-provider-google#23040

iap: removed deprecated `google_iap_brand` and `google_iap_client` resources
iap: removed deprecated `google_iap_client` data source

@modular-magician

This comment was marked as outdated.

@c2thorn

c2thorn commented Aug 18, 2026

Copy link
Copy Markdown
Member Author

Test failures should all be unrelated

@c2thorn

c2thorn commented Aug 18, 2026

Copy link
Copy Markdown
Member Author

@modular-magician reassign-reviewer

@github-actions

Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@github-actions
github-actions Bot requested a review from rileykarson August 18, 2026 16:51
@c2thorn
c2thorn force-pushed the remove-iap-brand-client branch from 6c0fd64 to 35176f9 Compare August 18, 2026 18:37
@modular-magician

This comment was marked as outdated.

@c2thorn
c2thorn force-pushed the remove-iap-brand-client branch from 35176f9 to 4c925e6 Compare August 18, 2026 19:47
@modular-magician

This comment was marked as outdated.

@c2thorn
c2thorn force-pushed the remove-iap-brand-client branch from 4c925e6 to 7f2cbbf Compare August 18, 2026 20:51
@modular-magician

modular-magician commented Aug 18, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 7f2cbbf:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 13 files changed, 10 insertions(+), 1736 deletions(-)
google-beta provider View Diff 13 files changed, 10 insertions(+), 1736 deletions(-)
terraform-google-conversion View Diff 3 files changed, 269 deletions(-)

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

  • Resource google_iap_brand was either removed or renamed - reference
  • Resource google_iap_client was either removed or renamed - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

Errors

google-beta provider:

  • Error reading file website/docs/d/iap_client.html.markdown
  • Error reading file website/docs/r/iap_brand.html.markdown
  • Error reading file website/docs/r/iap_client.html.markdown

Test report

Analytics

Total Tests Passed Skipped Affected
6868 6098 688 82
Affected Service Packages
  • All service packages are affected

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 82 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccAlloydbCluster_secondaryClusterPromoteAndSimultaneousUpdate
  • TestAccAlloydbCluster_secondaryClusterPromoteWithNetworkConfigAndAllocatedIPRange
  • TestAccAppEngineStandardAppVersion_appEngineStandardAppVersionBundledServicesExample
  • TestAccBigQueryDataset_basic
  • TestAccBigQueryDataset_bigqueryDatasetResourceTags_update
  • TestAccBigQueryDataset_externalCatalogDatasetOptions_update
  • TestAccCESToolset_cesToolsetOpenapiServiceAccountAuthConfigExample_update
  • TestAccColabNotebookExecution_colabNotebookExecutionBasicExample
  • TestAccColabNotebookExecution_colabNotebookExecutionCustomEnvExample
  • TestAccColabNotebookExecution_colabNotebookExecutionDataformExample
  • TestAccColabNotebookExecution_colabNotebookExecutionFullExample
  • TestAccComputeDisk_deleteDetach
  • TestAccComputeDisk_multiWriter
  • TestAccComputeInstanceFromMachineImageWithOverride_localSsdRecoveryTimeout
  • TestAccComputeInstanceFromMachineImageWithOverride_partnerMetadata
  • TestAccComputeInstanceFromMachineImage_basic
  • TestAccComputeInstanceFromMachineImage_confidentialInstanceConfigMain
  • TestAccComputeInstanceFromMachineImage_diffProject
  • TestAccComputeInstanceFromMachineImage_localSsdRecoveryTimeout
  • TestAccComputeInstanceFromMachineImage_maxRunDuration
  • TestAccComputeInstanceFromRegionTemplate_basic
  • TestAccComputeInstanceFromTemplateWithOverride_interface
  • TestAccComputeInstanceFromTemplateWithOverride_localSsdRecoveryTimeout
  • TestAccComputeInstanceFromTemplateWithOverride_partnerMetadata
  • TestAccComputeInstanceFromTemplate_DiskForceAttach
  • TestAccComputeInstanceFromTemplate_IgmpQuery_v2
  • TestAccComputeInstanceFromTemplate_VSSWindows
  • TestAccComputeInstanceFromTemplate_basic
  • TestAccComputeInstanceFromTemplate_confidentialInstanceConfigMain
  • TestAccComputeInstanceFromTemplate_diskResourcePolicies
  • TestAccComputeInstanceFromTemplate_localSsdRecoveryTimeout
  • TestAccComputeInstanceFromTemplate_maxRunDuration_onInstanceStopAction
  • TestAccComputeInstanceFromTemplate_overrideAttachedDisk
  • TestAccComputeInstanceFromTemplate_overrideBootDisk
  • TestAccComputeInstanceFromTemplate_overrideMetadataDotStartupScript
  • TestAccComputeInstanceFromTemplate_overrideScheduling
  • TestAccComputeInstanceFromTemplate_overrideScratchDisk
  • TestAccComputeInstanceFromTemplate_partnerMetadata
  • TestAccComputeInstanceFromTemplate_schedulingPreemptionNoticeDuration
  • TestAccComputeInstanceFromTemplate_self_link_unique
  • TestAccComputeInstanceFromTemplate_useDiskSelfLink
  • TestAccComputeInstanceFromTemplate_workloadIdentity
  • TestAccComputeInstance_attachDisk_forceAttach
  • TestAccComputeInstance_attachedDisk
  • TestAccComputeInstance_attachedDiskUpdate
  • TestAccComputeInstance_attachedDisk_RSAencryption
  • TestAccComputeInstance_attachedDisk_modeRo
  • TestAccComputeInstance_attachedDisk_sourceUrl
  • TestAccComputeInstance_bootAndAttachedDisk_interface
  • TestAccComputeInstance_diskEncryption
  • TestAccComputeInstance_diskEncryptionRestart
  • TestAccComputeInstance_instanceEncryption
  • TestAccComputeInstance_internalIPv6PrefixLength
  • TestAccComputeInstance_kmsDiskEncryption
  • TestAccComputeInstance_localSsdVM_maxRunDuration_stopTerminationAction
  • TestAccComputeInstance_serviceAccountEmail_0scopes
  • TestAccComputeInstance_serviceAccount_updated
  • TestAccComputeInstance_serviceAccount_updated0to1to0scopes
  • TestAccComputeInstance_stopInstanceToUpdate
  • TestAccComputeInstance_subnetworkUpdate
  • TestAccComputeInstance_with375GbScratchDisk
  • TestAccComputeRegionDisk_deleteDetach
  • TestAccComputeRouterPeer_AddMd5AuthenticationKey
  • TestAccComputeSecurityPolicy_withPreconfiguredWafConfig
  • TestAccDataSourceComputeInstance_basic
  • TestAccDataSourceComputeInstance_networkAttachmentUsageExample
  • TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample
  • TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
  • TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample
  • TestAccProjectIamMemberRemove_memberInMultipleBindings
  • TestAccPubsubSubscription_pubsubSubscriptionTagsExample
  • TestAccSqlDatabaseInstance_editionUpdateForEnhancedBackupTierInstance
  • TestAccSqlDatabaseInstance_performanceCaptureConfig
  • TestAccVertexAIFeatureOnlineStoreFeatureview_vertexAiFeatureonlinestoreFeatureview_featureRegistry_updated
  • TestAccVertexAIReasoningEngine_vertexAiReasoningEngineFullExample
  • TestAccVertexAIReasoningEngine_vertexAiReasoningEngineIdentityTypeUpdate
  • TestAccVertexAIReasoningEngine_vertexAiReasoningEngineUpdate
  • TestAccWorkbenchInstance_updateDeleteProtection
  • TestAccWorkbenchInstance_updateJupyterLab
  • TestAccWorkbenchInstance_updateMinCpuPlatform
  • TestAccWorkbenchInstance_updateResourcePolicies
  • TestAccWorkstationsWorkstationCluster_workstationClusterUrlsExample

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccAlloydbCluster_secondaryClusterPromoteAndSimultaneousUpdate
✅ Log TestAccAlloydbCluster_secondaryClusterPromoteWithNetworkConfigAndAllocatedIPRange
✅ Log TestAccAppEngineStandardAppVersion_appEngineStandardAppVersionBundledServicesExample
✅ Log TestAccBigQueryDataset_basic
✅ Log TestAccBigQueryDataset_bigqueryDatasetResourceTags_update
✅ Log TestAccBigQueryDataset_externalCatalogDatasetOptions_update
✅ Log TestAccCESToolset_cesToolsetOpenapiServiceAccountAuthConfigExample_update
✅ Log TestAccColabNotebookExecution_colabNotebookExecutionBasicExample
✅ Log TestAccColabNotebookExecution_colabNotebookExecutionCustomEnvExample
✅ Log TestAccColabNotebookExecution_colabNotebookExecutionDataformExample
✅ Log TestAccColabNotebookExecution_colabNotebookExecutionFullExample
✅ Log TestAccComputeDisk_deleteDetach
✅ Log TestAccComputeDisk_multiWriter
✅ Log TestAccComputeInstanceFromMachineImageWithOverride_localSsdRecoveryTimeout
✅ Log TestAccComputeInstanceFromMachineImageWithOverride_partnerMetadata
✅ Log TestAccComputeInstanceFromMachineImage_basic
✅ Log TestAccComputeInstanceFromMachineImage_confidentialInstanceConfigMain
✅ Log TestAccComputeInstanceFromMachineImage_localSsdRecoveryTimeout
✅ Log TestAccComputeInstanceFromMachineImage_maxRunDuration
✅ Log TestAccComputeInstanceFromRegionTemplate_basic
✅ Log TestAccComputeInstanceFromTemplateWithOverride_interface
✅ Log TestAccComputeInstanceFromTemplateWithOverride_localSsdRecoveryTimeout
✅ Log TestAccComputeInstanceFromTemplateWithOverride_partnerMetadata
✅ Log TestAccComputeInstanceFromTemplate_DiskForceAttach
✅ Log TestAccComputeInstanceFromTemplate_IgmpQuery_v2
✅ Log TestAccComputeInstanceFromTemplate_VSSWindows
✅ Log TestAccComputeInstanceFromTemplate_basic
✅ Log TestAccComputeInstanceFromTemplate_confidentialInstanceConfigMain
✅ Log TestAccComputeInstanceFromTemplate_diskResourcePolicies
✅ Log TestAccComputeInstanceFromTemplate_localSsdRecoveryTimeout
✅ Log TestAccComputeInstanceFromTemplate_maxRunDuration_onInstanceStopAction
✅ Log TestAccComputeInstanceFromTemplate_overrideAttachedDisk
✅ Log TestAccComputeInstanceFromTemplate_overrideBootDisk
✅ Log TestAccComputeInstanceFromTemplate_overrideMetadataDotStartupScript
✅ Log TestAccComputeInstanceFromTemplate_overrideScheduling
✅ Log TestAccComputeInstanceFromTemplate_overrideScratchDisk
✅ Log TestAccComputeInstanceFromTemplate_partnerMetadata
✅ Log TestAccComputeInstanceFromTemplate_schedulingPreemptionNoticeDuration
✅ Log TestAccComputeInstanceFromTemplate_self_link_unique
✅ Log TestAccComputeInstanceFromTemplate_useDiskSelfLink
✅ Log TestAccComputeInstanceFromTemplate_workloadIdentity
✅ Log TestAccComputeInstance_attachDisk_forceAttach
✅ Log TestAccComputeInstance_attachedDisk
✅ Log TestAccComputeInstance_attachedDiskUpdate
✅ Log TestAccComputeInstance_attachedDisk_RSAencryption
✅ Log TestAccComputeInstance_attachedDisk_modeRo
✅ Log TestAccComputeInstance_attachedDisk_sourceUrl
✅ Log TestAccComputeInstance_bootAndAttachedDisk_interface
✅ Log TestAccComputeInstance_diskEncryption
✅ Log TestAccComputeInstance_diskEncryptionRestart
✅ Log TestAccComputeInstance_instanceEncryption
✅ Log TestAccComputeInstance_internalIPv6PrefixLength
✅ Log TestAccComputeInstance_kmsDiskEncryption
✅ Log TestAccComputeInstance_localSsdVM_maxRunDuration_stopTerminationAction
✅ Log TestAccComputeInstance_serviceAccountEmail_0scopes
✅ Log TestAccComputeInstance_serviceAccount_updated
✅ Log TestAccComputeInstance_serviceAccount_updated0to1to0scopes
✅ Log TestAccComputeInstance_stopInstanceToUpdate
✅ Log TestAccComputeInstance_subnetworkUpdate
✅ Log TestAccComputeInstance_with375GbScratchDisk
✅ Log TestAccComputeRegionDisk_deleteDetach
✅ Log TestAccComputeRouterPeer_AddMd5AuthenticationKey
✅ Log TestAccDataSourceComputeInstance_basic
✅ Log TestAccDataSourceComputeInstance_networkAttachmentUsageExample
✅ Log TestAccSqlDatabaseInstance_editionUpdateForEnhancedBackupTierInstance
✅ Log TestAccSqlDatabaseInstance_performanceCaptureConfig
✅ Log TestAccVertexAIReasoningEngine_vertexAiReasoningEngineFullExample
✅ Log TestAccVertexAIReasoningEngine_vertexAiReasoningEngineIdentityTypeUpdate
✅ Log TestAccVertexAIReasoningEngine_vertexAiReasoningEngineUpdate
✅ Log TestAccWorkbenchInstance_updateDeleteProtection
✅ Log TestAccWorkbenchInstance_updateJupyterLab
✅ Log TestAccWorkbenchInstance_updateMinCpuPlatform
✅ Log TestAccWorkbenchInstance_updateResourcePolicies
✅ Log TestAccWorkstationsWorkstationCluster_workstationClusterUrlsExample
✅ Log ❌ Error · Log TestAccProjectIamMemberRemove_memberInMultipleBindings
❌ Error · Log - TestAccComputeInstanceFromMachineImage_diffProject
❌ Error · Log - TestAccComputeSecurityPolicy_withPreconfiguredWafConfig
❌ Error · Log - TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample
❌ Error · Log - TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
❌ Error · Log - TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample
❌ Error · Log - TestAccPubsubSubscription_pubsubSubscriptionTagsExample
❌ Error · Log - TestAccVertexAIFeatureOnlineStoreFeatureview_vertexAiFeatureonlinestoreFeatureview_featureRegistry_updated

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

🔴 Replaying Rerun Failed: Some tests failed due to non-determinism when VCR replayed the response. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@c2thorn VCR tests complete for 7f2cbbf!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants