Fix Gradle 10 issue in DefaultNmcpSettings#270
Merged
Conversation
Fix the Gradle 10 deprecation warning in `DefaultNmcpSettings` by using `DependencyHandler.project()` instead of `DependencyHandler.create()`. Using the other recommended way via `DependencyFactory.createProjectDependency()` isn't available in NMCP's min Gradle-API version 8.8. Warning message and location: ``` Using a Project object as a dependency notation has been deprecated. This will fail with an error in Gradle 10. Please use the project(String) method on DependencyHandler or the createProjectDependency(String) method on DependencyFactory instead. Consult the upgrading guide for further information: https://docs.gradle.org/9.6.1/userguide/upgrading_version_9.html#dependency_project_notation at nmcp.internal.DefaultNmcpSettings.lambda$0$1(DefaultNmcpSettings.kt:37) at nmcp.internal.DefaultNmcpSettings.lambda$0$2(DefaultNmcpSettings.kt:36) ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the Gradle 10 deprecation warning in
DefaultNmcpSettingsby usingDependencyHandler.project()instead ofDependencyHandler.create().Using the other recommended way via
DependencyFactory.createProjectDependency()isn't available in NMCP's min Gradle-API version 8.8.Warning message and location: