Coalesce Predicate Information and Improve Predicate Testing

[ghzdude]

What

Multipredicates should now be able to be treated like base predicates for testing min/max counts

Implementation Details

Added record PredicateSettings which combines several of BasePredicate's fields
MultiPredicate also has a settings field, which is nonnull by default
MultiPredicate settings are checked along with their children
getPredicateAtPos() now returns a PredicateResult record, which stores the matched base predicate and a parent chain
BasePredicate's Air/any fields are removed and handled completely in MultiPredicate
multi predicate and base predicate have copy, equals, and hash methods
the predicate context counts both base predicates and multi predicates
added TestType enum to clean up testing logic between base predicate and multi predicate

AI Usage

• No AI driven tools were used for this pull request.
• Yes AI driven tools were used for this pull request.

Outcome

you should be able to do a.or(b).setMinCount(4) to mean "4 combined of either predicates" now

How Was This Tested

ran client, only check the assembly line which formed as expected

[jurrejelle]

Edit to add: review assisted by opus

[jurrejelle]

Sidenote, but tests blow up for now x3 something while forming a multi crashes

[ghzdude]

So, the reason many tests were failing is due to certain multiblocks, namely the Large Chemical Reactor, not forming correctly. The formation failure is because the global/slice count maps can have "duplicated" keys. The keys are being duplicated because they (base predicates and multi predicates) are being copied in the MultiPredicate#combine() method.

A quick fix is to stop copying on combination, but this then results in undesirable mutation (parents) when using the same multipredicate reference combined with two other multi predicates. like so:

var a = blocks(...)
var b = blocks(...).and(a) // a is parent to {a + b}
var c = blocks(...).and(a) // a is now parent to {a + c}

I could use a list of parents, but then it becomes difficult to determine which parent to call in MultiPredicate#testParents(), and testing all of them can result in the same multi predicate being counted multiple times

I've also made an attempt to implement an equals method for BasePredicate and TestablePredicate, but this doesn't seem to help, the duplicate keys are still present in the count maps. I'm not entirely sure how to fix this.