Use holders for GT content registration on 1.21 - #5358
Merged
Merged
Conversation
gustovafing
added
1.21.1
ignore changelog
gustovafing
marked this pull request as ready for review
August 31, 2026 01:12
github-actions
Bot
added
Tests: Failed
htmlcsjs
reviewed
Sep 5, 2026
htmlcsjs
left a comment
htmlcsjs
left a comment
Member
There was a problem hiding this comment.
I have read though the code and tested some stuff ingame, admitidly alot of it went over my head but i would appreciate someone else looking through this
| } | ||
|
|
||
| public static void init() { | ||
| PlaceholderHandler.addPlaceholder(new Placeholder("ae2itemCount") { |
Member
There was a problem hiding this comment.
Does the change from camelCase to snake_case here break preexisting monitors?
Member
Author
There was a problem hiding this comment.
It will, but that's not really a big concern on 1.21
Contributor
There was a problem hiding this comment.
This is fine; as no 1.21 stable version has been released to break yet
gustovafing
added this pull request to stack #5411
September 9, 2026 08:23
Reabstraction
left a comment
Reabstraction
left a comment
Contributor
There was a problem hiding this comment.
Mostly good, just two nitpicks
| } | ||
|
|
||
| public static void init() { | ||
| PlaceholderHandler.addPlaceholder(new Placeholder("ae2itemCount") { |
Contributor
There was a problem hiding this comment.
This is fine; as no 1.21 stable version has been released to break yet
Reabstraction
approved these changes
Sep 13, 2026
gustovafing
force-pushed
the
gus/use-holders-1.21
branch
from
September 13, 2026 10:29
2a2e8c0 to
342d917
Compare
github-actions
Bot
added
Tests: Failed
github-actions
Bot
added
Tests: Passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Wraps GT content registration in deferred holders, for everything except machines, material system stuff and recipe stuff (they will be handled in seperate PRs each).
No AI