fix(event-display): stop animations overriding cut and label visibility

[EdwardMoyse]

The bug

Running an animation makes objects reappear that an active cut had hidden. The Phoenix menu still shows the cut as applied, so the GUI and the 3D scene disagree.

Reproduced with a 122411 MeV CaloCluster in CaloCalTopoCluster_xAOD, hidden by an energy cut, which comes back as soon as the animation runs:

https://phoenixatlas.web.cern.ch/PhoenixATLAS/?file=data%2FBriefings%2FJiveXML_481638_696395260.xml&theme=dark&type=jivexml&config=data%2FBriefings%2Frun481638_evt696395260.json

Cause

Cuts and the animation both drive the same Object3D.visible flag, and the animation treats it as if it owns it.

SceneManager.collectionFilter hides a filtered object with child.visible = false. animateEvent then hides every generic event object at the start, and reveals each one as the expanding animation sphere reaches it:

} else if (updateAnimationSphere.containsPoint(obj.position)) {
  obj.eventObject.visible = true;   // unconditional
}

It never checks whether the object was visible to begin with. The completion handler then calls that same update with a sphere of infinite radius:

animationSphereTweenClone.onComplete(() => {
  onAnimationSphereUpdate(new Sphere(new Vector3(), Infinity));

so at the end of every animation every cut-hidden object in the event is forced visible. The Cut model is never touched, which is exactly why the menu still reports the cut as active — the scene has simply stopped honouring it.

Fix

Objects now record whether they were visible before the animation hid them, and are restored to that state rather than switched on.

animateEventWithClipping is unaffected by this part: it animates with clipping planes and never touches visible.

Labels: the same defect, two more places

Noticed while reading the same function, and fixed here too:

• animateEvent hid the labels group on start and restored it with an unconditional visible = true, so running an animation with labels toggled off turned them back on.
• animateEventWithClipping hid the labels group on start and never restored it at all — labels stayed hidden after every clipping animation.

Both now remember and restore the previous state.

Tests

Three regression tests added, each verified to fail without its fix:

• should keep objects hidden by a cut hidden through the animation — builds a CaloCalTopoCluster_xAOD collection with one passing cluster and one cut-hidden 122411 cluster, runs the animation to completion, and asserts the cut one stays hidden while the other still animates in. Without the fix: Expected: false, Received: true.
• should restore the labels after a clipping animation
• should leave labels off after an animation if they were toggled off

Full phoenix-event-display suite: 402 tests pass. Prettier and eslint clean.

🤖 Generated with Claude Code

[github-actions]

🚀 Preview deployed: http://phoenix-pr-1038.surge.sh

Built from cea8ba7.