feat(event-display): load zipped version of event data in a generic way (#441) - #1040
Open
DashratRajpurohit wants to merge 3 commits into
Open
DashratRajpurohit wants to merge 3 commits into
DashratRajpurohit wants to merge 3 commits into
Conversation
DashratRajpurohit
force-pushed
the
feat/441-generic-zip-event-data
branch
from
September 27, 2026 13:53
51336cd to
a7c4a27
Compare
|
🚀 Preview deployed: http://phoenix-pr-1040.surge.sh Built from cf8ae6e. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves Issue #441 by centralizing and making zip event loading generic across
phoenix-event-displayandphoenix-ui-components.Key Changes
loadEventsFromZiphelper inpackages/phoenix-event-display/src/helpers/zip.tsthat handles reading.zipfiles containing JSON or JiveXML event data.parseZipEventDataonEventDisplay: AddedEventDisplay.parseZipEventData(zipData)to simplify parsing zip event archives from both files and ArrayBuffers.URLOptionsManager.handleZipFileEventsandIOOptionsDialogComponent.handleZipEventDataInputto useparseZipEventData..zip/.phnxzip) inURLOptionsManagerwhentypeparameter is omitted in URL query params.packages/phoenix-event-display/src/tests/helpers/zip.test.ts.Closes #441