Support analytics adapters in generated Prebid bundles - #1090
Open
ChristianPavilonis wants to merge 5 commits into
Open
Support analytics adapters in generated Prebid bundles#1090ChristianPavilonis wants to merge 5 commits into
ChristianPavilonis wants to merge 5 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pbjs.enableAnalyticscan use adapters such as ATS without missing-registry errors.Changes
crates/trusted-server-cli/src/prebid_bundle.rscrates/trusted-server-js/lib/build-prebid-external.mjscrates/trusted-server-js/lib/src/integrations/prebid/index.tscrates/trusted-server-js/lib/src/integrations/prebid/user_id_modules.jsoncrates/trusted-server-js/lib/src/integrations/prebid/user_id_modules.tsimportPathfield from the registry type.crates/trusted-server-js/lib/test/build-prebid-external.test.mjscrates/trusted-server-js/lib/test/integrations/prebid/index.test.tscrates/trusted-server-js/lib/test/prebid-artifact-integration.test.mjsdocs/guide/cli.mddocs/guide/integrations/prebid.mddocs/superpowers/plans/2026-08-28-prebid-bundle-module-map.mddocs/superpowers/specs/2026-08-28-prebid-bundle-module-map-design.mdtrusted-server.example.tomlScope
This pull request changes the Rust command-line interface, Node.js bundle generator, browser diagnostics, tests, and operator documentation because they share one configuration and manifest contract. It is limited to modules shipped by the locked Prebid.js package. It does not add custom module paths, download third-party adapters, or move
pbjs.enableAnalyticsoptions out of publisher code.Closes
Closes #1085
Test plan
cargo test-fastly && cargo test-axumcargo clippy-fastly && cargo clippy-axumcargo fmt --all -- --checkcd crates/trusted-server-js/lib && npx vitest runcd crates/trusted-server-js/lib && npm run formatcd docs && npm run formatcargo build --package trusted-server-adapter-fastly --release --target wasm32-wasip1fastly compute servecargo test-cloudflare,cargo test-spin, all six target-matched Clippy commands, parity tests, CLI tests, JavaScript build, documentation build, a real bundle smoke test, and the unsupported-module failure path.Checklist
unwrap()in production code; new fallible paths return actionable errors