Repository navigation
docs(contributing): align test and development instructions - #628
Merged
DhavalRepo18 merged 1 commit intoOct 11, 2026
Merged
Conversation
Signed-off-by: Youssef Faouzi <46967695+yousseffaouzi@users.noreply.github.com>
yousseffaouzi
added a commit
to yousseffaouzi/AssetOpsBench
that referenced
this pull request
Oct 11, 2026
Signed-off-by: Youssef Faouzi <46967695+yousseffaouzi@users.noreply.github.com>
DhavalRepo18
self-requested a review
October 11, 2026 21:29
DhavalRepo18
approved these changes
Oct 11, 2026
DhavalRepo18
approved these changes
Oct 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was broken
The contributor guide and PR templates used test paths that do not exist in the current repository:
uv run pytest tests/unituv run pytest tests/integration./scripts/run_tests.shThe tests actually live under
src/, andINSTRUCTIONS.mdalready documents the supported test selection.CONTRIBUTING.mdalso assumed Ruff was available through the development dependencies even though it is not declared in the currentpyproject.toml.Changes
uv run pytest src/ -k "not integration"for the service-free test selection.uv run pytest src/for the full suite, subject to documented integration prerequisites.scripts/run_tests.shscript.uvx ruffand note that whole-repository checks report existing unrelated diagnostics.Scope: contributor documentation only. There are no benchmark behavior, scoring, baseline, or dependency changes. Existing PR #331 separately handles adding Ruff to development dependencies.
Verification
uv sync --frozenpassed.uv run --frozen pytest src/llm/tests src/servers/utilities/tests -q33 passed, including re-running against the published branch.git diff --check upstream/main...docs/fix-contributor-test-instructionspassed.uv run --frozen pytest src/ -k "not integration"collected 720 tests, with 13 deselected and 707 selected; terminated with exit code 137 in the available environment before completion. A full-suite pass is not claimed.uvx ruff check .1,210 existing repository-wide findings.uvx ruff format --check .84 existing files reported as needing reformatting. No Python code is changed in this PR.The commit includes a DCO sign-off matching its GitHub author address.