fix: align power electronics constraints with API - #272
Open
SoheylM wants to merge 2 commits into
Open
Conversation
g-braeunlich
reviewed
Sep 4, 2026
g-braeunlich
left a comment
Collaborator
There was a problem hiding this comment.
Only some very minor suggestions!
Comment on lines
19
to
20
| if line.strip() != "": | ||
| parts = line.split() |
Collaborator
There was a problem hiding this comment.
Suggested change
| if line.strip() != "": | |
| parts = line.split() | |
| parts = line.split() | |
| if len(parts) <= 2: | |
| continue |
Then you dont need to catch the IndexError
|
|
||
| def test_duty_cycle_must_be_a_fraction(problem: PowerElectronics) -> None: | ||
| design = VALID_DESIGN.copy() | ||
| design[9] = -0.1 |
Collaborator
There was a problem hiding this comment.
How about using DUTY_CYCLE here?
| @pytest.mark.parametrize("duty_cycle", [0.001, 0.998]) | ||
| def test_duty_cycle_must_produce_increasing_pwl_times(problem: PowerElectronics, duty_cycle: float) -> None: | ||
| design = VALID_DESIGN.copy() | ||
| design[9] = duty_cycle |
|
|
||
| def test_switch_levels_must_be_binary(problem: PowerElectronics) -> None: | ||
| design = VALID_DESIGN.copy() | ||
| design[10] = 0.5 |
Collaborator
There was a problem hiding this comment.
Maybe SWITCH_LEVELS[0] instead of 10?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Align the Power Electronics v0 problem with the constraint API described in the current documentation.
Part of #243 (Power Electronics).
Type of change
Screenshots
Not applicable.
Validation
Local environment notes:
Checklist
The unchecked warning item is intentional: invalid ngspice output now raises a dedicated warning while preserving NaNs for batch processing. The unchecked test and mypy items are explained in the validation notes above.
Reviewer Checklist