chore: cleanup go-api azure-pipline - #238
Merged
Merged
Conversation
this is replaced by argocd based deployment
thenav56
marked this pull request as ready for review
September 16, 2026 14:22
thenav56
force-pushed
the
chore/go-api-cleanup
branch
from
September 16, 2026 14:22
7eb9e97 to
653b2c9
Compare
Production applies ran unreviewed: plan-infra.sh was wired only to PRs targeting develop.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
go-api now deploys via ArgoCD (ns
go-api). This removes the legacy pipeline, Helm release and Terraform leftovers.Checklist
IFRCGO - backenddisable - https://dev.azure.com/IFRC/IFRC_GO/_build?definitionId=240Staging (merge to
develop)helm_release.ifrcgodropped from state (not uninstalled);ifrctgo-disk001, its Contributor role assignment and theifrcgo-terraform-managed-resourcesConfigMap destroyed.StatefulSet ifrcgo-helm-ssh-bastion,Service ssh-bastion, 3 ConfigMaps,Secret ifrcgo-helm-api-secret. Nothing in nsgo-api.system:serviceaccount:go-api:service-token-reader(Terraform-managed, namedgo-api-staging-secret-reader-identity).az identity federated-credential list \ --identity-name GoApiStagingWorkloadIdentity \ --resource-group ifrctgo002rg \ --query "[].{name:name, subject:subject}" -o tablesystem:serviceaccount:default:...subject, delete it. It is unmanaged and was created outside Terraform, so its name is not predictable: take it from the listing above.Production (merge to
master)ifrcpgo-disk001.go-api-production-secret-reader-identity.az identity federated-credential list \ --identity-name GoApiProductionWorkloadIdentity \ --resource-group ifrcpgo002rg \ --query "[].{name:name, subject:subject}" -o tablesystem:serviceaccount:default:...subject.Follow-up PR (after both environments) #240
resources/helm-ifrcgo.tf(theremovedblock).provider "kubernetes"inresources/aks.tfand thekubernetesentry inresources/providers.tf. Cannot be done earlier: Terraform needs the provider present to destroy the ConfigMap.terraform/imports.tf.resources/bastion.tf:8-11and the values-file reference at:51.README.md:14: drop theapplications/go-apientry.STAGING_*/PRODUCTION_*secret variables. Leave theIFRCGoservice connection, whichbase-infrastructure/azure-pipelines.ymluses.