Align/fix all logical source descriptors

[lacoak21]

Change Summary

Does not fully close #3438

I am not able to access the l3 attributes from imap_processing so the SWAPI and SWE l3 issues are still present.

Overview

• I confirmed that the MAG logical source descriptors now contain "MAG". I checked that all other instrument logical source descriptors have both "IMAP" and the instrument name.
• I removed "." from all logical source descriptors. There should not be any according to the ISTP global attr examples

File changes

Remove "." from all logical source descriptors. There should not be any according to the ISTP global attr examples

https://istp-metadata.readthedocs.io/en/v1.0.0/source/03_metadata-global-attributes.html

[Copilot]

🟡 Changes recommended

The I-ALiRT description retains a trailing period, and two updated Ultra descriptions contain a spelling error.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Aligns CDF logical-source descriptions with ISTP metadata conventions by removing trailing periods.

Changes:

• Removes terminal periods from instrument and spacecraft metadata.
• Updates affected HIT and Ultra test expectations.

File summaries

File	Description
imap_processing/tests/ultra/unit/test_ultra_l1b.py	Updates Ultra metadata assertion.
imap_processing/tests/hit/test_hit_utils.py	Updates HIT metadata assertion.
imap_processing/cdf/config/imap_ultra_global_cdf_attrs.yaml	Revises Ultra descriptions.
imap_processing/cdf/config/imap_spacecraft_global_cdf_attrs.yaml	Revises spacecraft descriptions.
imap_processing/cdf/config/imap_mag_global_cdf_attrs.yaml	Revises MAG descriptions.
imap_processing/cdf/config/imap_idex_global_cdf_attrs.yaml	Revises IDEX descriptions.
imap_processing/cdf/config/imap_hit_global_cdf_attrs.yaml	Revises HIT descriptions.
imap_processing/cdf/config/imap_hi_global_cdf_attrs.yaml	Revises Hi descriptions.
imap_processing/cdf/config/imap_glows_global_cdf_attrs.yaml	Revises GLOWS descriptions.
imap_processing/cdf/config/imap_codice_global_cdf_attrs.yaml	Revises CoDICE descriptions.

Review details

Suppressed comments (1)

imap_processing/cdf/config/imap_ultra_global_cdf_attrs.yaml:22

• Auxilliary is misspelled in this updated metadata value; use Auxiliary, consistent with the Data_type immediately above.

    Logical_source_description: IMAP-Ultra Instrument Level-1A Auxilliary Data

• Files reviewed: 10/10 changed files
• Comments generated: 2
• Review effort level: Balanced

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[bryan-harter]

Ah good find about the periods!

Also I realized I was totally unclear, but for the SWAPI and SWE changes, I meant SWAPI (all-levels) and SWE (only L3). So there should still be a few things to change with SWAPI in this repo.

I think we can also close the ticket (or move it to "validating") if you wouldn't mind adding a ticket for the L3 changes to the imap_l3_processing repo

[lacoak21]

Great. Looks like all of SWAPI's levels look fine in the global yaml file. I think this may have been fixed already?

[bryan-harter]

Oh gotcha! In that case, looks good to me!