Fix URL signing api for URLs containing special characters#12435
Open
ErykKul wants to merge 17 commits into
Open
Fix URL signing api for URLs containing special characters#12435ErykKul wants to merge 17 commits into
ErykKul wants to merge 17 commits into
Conversation
ErykKul
added
Size: 3
|
Coverage is 24.989% — fix-url-signing-special-characters into develop. No base build found for |
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
…cial-characters' into fix-url-signing-special-characters # Conflicts: # doc/release-notes/fix-url-signing-special-characters.md # src/main/java/edu/harvard/iq/dataverse/api/Access.java
This comment has been minimized.
This comment has been minimized.
stevenwinship
approved these changes
Jun 16, 2026
github-project-automation
Bot
moved this from In Review 🔎
to Ready for QA ⏩
in IQSS Dataverse Project
cmbz
added
FY26 Sprint 25
This comment has been minimized.
This comment has been minimized.
…pping, docs and tests #12435 - Gate the four signed-URL POST /api/access endpoints before any guestbook-response or MakeDataCount side effects, via requireSigningSecretForSignedUrl(); keep a silent backstop in returnSignedUrl for the callers that discard its response. Generic error message for these guest-reachable endpoints, actionable detail in the server log. - stripReservedParameters: preserve empty query segments and fragments byte-for-byte (split("&", -1), fragment split off before query surgery). - Log a warning and hide the permissions-history CSV link when no signing secret is set. - Tests: unsigned-fallback path, signUrlWithApiKey/isSigningSecretConfigured, strip edge cases. - Docs: signing-secret now documented as required in native-api.rst; fix env var name DATAVERSE_API_SIGNING_SECRET in config.rst; conditional-signing notes in external-tools.rst and globus-api.rst; release note lists all gated endpoints and the real error message.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Member
|
@ErykKul I'm putting this on hold for now since I heard you're on vacation until Aug 4. Please resolve merge conflicts when you get back. Thanks! |
…ecial-characters # Conflicts: # src/main/java/edu/harvard/iq/dataverse/api/Access.java
Collaborator
Author
|
@pdurbin, I did the merge. This one was easy. If there is something bigger, then I will pick it up after Aug 4. |
|
📦 Pushed preview images as 🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Bug fix; URL signing for URLs containing special characters broken in 6.10, this PR fixes the introduced bug.
Which issue(s) this PR closes:
Issue not created, bug fixed directly here.
Special notes for your reviewer:
Added tests to prevent regression. Also, API requires now the signing secret to be set, otherwise it will not work.
Suggestions on how to test this:
No special testing needed, the unit tests should be sufficient.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
No
Is there a release notes update needed for this change?:
Yes, included.
Additional documentation:
No