Skip to content

[Dev] Remove mandatory scheduler reservations for GPU validation - #173

Merged
bjf-frz merged 1 commit into
mainfrom
docs/remove-gpu-reservation-requirement
Nov 6, 2026
Merged

bjf-frz merged 1 commit into
mainfrom
docs/remove-gpu-reservation-requirement

Conversation

@bjf-frz

@bjf-frz bjf-frz commented Nov 6, 2026

Copy link
Copy Markdown
Collaborator

Purpose

Remove the mandatory scheduler-reservation prerequisite for GPU validation. An explicit GPU-testing request can proceed on an available, explicitly selected device even when no scheduler is installed.

Update the review skill, pytest help/error/skip wording, marker description, and current serving/rerun instructions. Keep --run-gpu, explicit CUDA_VISIBLE_DEVICES, authorized experiment scope, and run budgets. Historical benchmark descriptions remain unchanged.

Required human contributor answers

1. What outcome are you trying to achieve?

Allow requested GPU validation without blocking on a scheduler reservation.

2. What is the highest-leverage variable for that outcome?

The mandatory reservation prerequisite in the review workflow.

3. How will this work move that variable rather than create busywork?

Remove the prerequisite and align the associated instructions and pytest wording with explicit device selection.

4. Who is the customer or user, and what do they actually need?

Contributors and reviewers running requested GPU tests on machines without a configured scheduler.

PR necessity and bugfix evidence

A PR is needed to remove the repository-wide requirement and its contradictory usage instructions. The existing review rule forbids unreserved execution, while the pytest guard only requires an explicit device selection. This is a workflow-policy correction; inference behavior and test gating logic are unchanged.

Test Plan

Run pre-commit run --all-files and git diff --check. Inspect remaining reservation references to distinguish current requirements from historical experiment facts. Runtime performance analysis is not applicable to policy/documentation and message-only changes.

vllm-rlt Version / Commit: base 444638beca89e95af6efb34a39fd3edf01c4020b

Test Result

  • pre-commit run --all-files: passed Ruff lint, Ruff format, and the CPU regression suite.
  • git diff --check: passed.
  • Six files changed, 14 insertions and 12 deletions.

@bjf-frz
bjf-frz merged commit e0a5515 into main Nov 6, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant