fix(tmp): try make clipboard patterns safe for Filter - #3622
Draft
Timongcraft wants to merge 2 commits into
Draft
Conversation
Contributor
Author
hm... |
dordsor21
reviewed
Aug 15, 2026
| || clipboard instanceof EmptyClipboard | ||
| || clipboard instanceof DiskOptimizedClipboard // FastSchematicReaderV2/V3 no min offset | ||
| || (clipboard instanceof BlockArrayClipboard blockArrayClipboard | ||
| && blockArrayClipboard.getParent() instanceof DiskOptimizedClipboard)) { |
Member
There was a problem hiding this comment.
I know it's still in draft, but perhaps we can add a #concurrentAccessSupported function to clipboard
Contributor
Author
There was a problem hiding this comment.
I appreciate the feedback!
that would be better I just wasn't sure if I should touch that but will do!
-> currently "wrongly" marked true in ConcurrentReadClipboard although it only wraps block reads
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Fix corruption when using ClipboardPattern and disabling on disk clipboards as some implementations have an unsafe cache.
This does not fix RandomFullClipboardPattern, which also seems affected but I'm not sure how to wrap the clipboard properly as it uses the old single get clipboard (seemingly on purpose) but idk if or how that should be wrapped as we'd need a map or list, no?
Description
Add a temporary wrapper to sync block access in clipboards for ClipboardPattern.
Submitter Checklist
- [ ] New public fields and methods are annotated with@since TODO.