Repository navigation
Conversation
- set version back to 1.4.1-SNAPSHOT - Downgrade Java 17 -> Java 11
- and some cleanups
- Codacy Review (cherry picked from commit 5749229)
- enable() and disable() in same Test
…ion (LibrePDF#1072) * LibrePDF#1057 Generating PDF from HTML containing CSS font-size property fails with IllegalArgumentException --------- Co-authored-by: Radek Wikturna <radek.wikturna@usu.com>
…plied (LibrePDF#1075) * LibrePDF#1061 When converting HTML to PDF, background color is not applied --------- Co-authored-by: Radek Wikturna <radek.wikturna@usu.com>
…F#1080) - Fixes some issues when building under Windows
…LibrePDF#1081) * LibrePDF#156: Throw Exception if PdfWriter.close() is called directly - Throw an IllegalStateException if PdfWriter.close() is called before Document.close() is called. - Delete old *.lng files in src/main/java - Update *.lng files in src/main/resources - BoyScout rule in PdfWriter * LibrePDF#156: Throw Exception if PdfWriter.close() is called directly - Codacy Issues (cherry picked from commit 6c675f7)
- add back explicit dependency to surefire and failsafe - reformat some files - use more String.getBytes(withEncoding) - Update Disabled-Comment in testSurrogatePair() - other Tests - display maven version in build - some changes to keep tests more robust (cherry picked from commit f17bca3)
- Use more UTF-8 in tests with passwords - rename methods to not have UTF-8 chars in their names
- moved to config/ - updated forIntelliJ - created for Eclipse - Editorconfig updated
- 4 runs of reformatting - all .java, .md, .yml and .html files - Only format changed
- Copy all inactive rules back to checkstyle.xml - Activated many rules. - Reduced real line-length from 235 to 180 - Fixes some checkstyle-lower-hanging-fruits (cherry picked from commit 9f8dceb)
- reformatted - developers: added asturio - scm just after developers - minor correction - checkstyle setup in pluginManagement - created "release"-profile - source, javadoc and gpg only run in "release"-profile - set version vor maven-site-plugin - gpg.skip not needed anymore - added -Prelease to createRelease.sh (cherry picked from commit 1da07d0)
Pick enhancements from 1.3 into 1.4 - Shandra's IndirectObjects - Lonzak's ECDSA fixes - Many @OVERRIDES - Javadoc - Cleanups
…tureTreeRoot (cherry picked from commit c710839)
fixes Jaspersoft/jasperreports#561 (cherry picked from commit 33eecab)
adds to 33eecab fixes Jaspersoft/jasperreports#561 fixes Jaspersoft/jasperreports#301 (cherry picked from commit c82bc87)
Signed-off-by: Tang Keyin <kevin_kda@yahoo.com.au>
….4.2 The Jaspersoft changes from 1.3.43.jaspersoft.2 are carried as the cherry-picked commits above, so the tree is OpenPDF 1.4.2 plus those changes. Signed-off-by: Tang Keyin <kevin_kda@yahoo.com.au>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR rebases the Jaspersoft classic OpenPDF fork from OpenPDF 1.3.43 onto OpenPDF 1.4.2, the last release of the
com.lowagie1.4 line. It keeps the Jaspersoft changes from1.3.43.jaspersoft.2and sets the version to1.4.2.jaspersoft.1-SNAPSHOT.Why
JasperReports uses
openpdf.classic.version=1.3.43.jaspersoft.2forjasperreports-pdf. Any project that also has stock OpenPDF 1.4.x on its classpath (directly or through another library) must either downgrade it to the 1.3.43 fork or run JasperReports against stock OpenPDF. The second option logsStock OpenPDF detected, link annotation /StructParent tagging is disabledand drops the glyph-position fixes (LibrePDF#561, LibrePDF#301). A1.4.2.jaspersoft.1release would remove that conflict for Java 11+ users. JasperReports 7 already requires Java 17.What
release-1.3.43.jaspersoft.2, each with its original author and an-xreference:PdfStructureTreeRootsubclassable and addPdfWriter.setStructureTreeRoot()1.4.2.jaspersoft.1-SNAPSHOTin the five poms.-s oursmerge ofrelease-1.3.43.jaspersoft.2, so the branch fast-forwards from this PR's base. The resulting tree is exactly upstream tag1.4.2plus the four commits above. The diff against the base is therefore upstream's1.3.43..1.4.2change (Java 11 baseline, deprecated API removals, dependency updates) plus the version bump.The changes to the three Java files are line-for-line identical to
1.3.43...1.3.43.jaspersoft.2. All three cherry-picks applied cleanly except for the pom version lines.If you would rather keep
release-1.3.43.jaspersoft.2unchanged, you can create a branch from tag1.4.2and retarget this PR to it. The first four commits apply on1.4.2as they are, and the merge commit can be dropped.Testing
On JDK 21 with Maven 3.9.16:
mvn -pl openpdf -am install: 1989 tests ran, with 1 failure and 4 skipped. The failure isDocumentTest.testThatVersionIsCorrect. Its regex^OpenPDF \d+\.\d+\.\d+(-SNAPSHOT)?$rejects any.jaspersoft.Nversion, including the existing1.3.43.jaspersoft.2, so I left the test unchanged.master(ext/pdfand its dependencies) compiles against the new jar with-Dopenpdf.classic.version=1.4.2.jaspersoft.1-SNAPSHOT.openpdf-1.4.2.jar, it logsStock OpenPDF detected ....%PDF-, 1067 bytes).