Repository navigation
Fix #562: pass image tensor to resize_image() in TF segmentation t_in - #616
Merged
Merged
Conversation
Collaborator
|
Good catch! Merging now. Thanks for your contribution 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #562.
In
TfSemanticSegmentationModel'st_ininput transform,resize_image()was called without its required first positional argument (image), raisingTypeErrorwhenever TF segmentation inference runs withresizeenabled. This passestensor(already produced bytf.convert_to_tensor(image)on the preceding line), consistent with theresize_image(image, ...)call at line ~191 and thecrop_center(tensor, ...)call immediately below it.resize_image(appears at only these two call sites in the codebase; this was the only affected one.