example of fixtures - #26
Open
joaomcteixeira wants to merge 1 commit into
Open
joaomcteixeira wants to merge 1 commit into
joaomcteixeira wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without going too deep into the matter, I just want to provide an example of
fixturesso that you can separate theassertstatements in different test functions.You can see that I transferred the file paths variables to the module level inside the
__init__.pyi found this a better practice because you can use them test-wide and this also provides a much easier implementation of thefixtures.I have not cleaned the
pre-commithook messages. But tests pass. Is just an example for you to consider.I am also not so proficient with
fixturesmaybe a more experienced developer withpytestcan provide a better solution, though I find this one very simple.