Skip to content

[Feat] mau 감사 로그 - #259

Merged
shinae1023 merged 3 commits into
devfrom
feat/audit-mau
Aug 1, 2026
Merged

[Feat] mau 감사 로그#259
shinae1023 merged 3 commits into
devfrom
feat/audit-mau

Conversation

@shinae1023

@shinae1023 shinae1023 commented Aug 1, 2026

Copy link
Copy Markdown
Member

✨ 어떤 이유로 PR를 하셨나요?

  • feature 병합
  • 버그 수정(아래에 issue #를 남겨주세요)
  • 코드 개선
  • 코드 수정
  • 배포
  • 기타(아래에 자세한 내용 기입해주세요)

📋 세부 내용 - 왜 해당 PR이 필요한지 작업 내용을 자세하게 설명해주세요

📸 작업 화면 스크린샷

⚠️ PR하기 전에 확인해주세요

  • 로컬테스트를 진행하셨나요?
  • 머지할 브랜치를 확인하셨나요?
  • 관련 label을 선택하셨나요?

🚨 관련 이슈 번호 [ ]

Summary by CodeRabbit

  • 새로운 기능
    • 로그인 성공 시 사용자 ID와 로그인 방식이 감사 로그에 기록됩니다.
    • 감사 로그 기록에 실패해도 로그인 처리는 정상적으로 계속됩니다.
    • 로컬 및 Google 소셜 로그인에 대한 성공 로그 기록이 검증되었습니다.

@coderabbitai

coderabbitai Bot commented Aug 1, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@shinae1023, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 47 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 8aedac9e-0232-4ce7-9ee0-7973ef211b18

📥 Commits

Reviewing files that changed from the base of the PR and between 465a1d1 and fb7bb00.

📒 Files selected for processing (2)
  • src/main/java/com/jobdri/jobdri_api/domain/audit/service/AuditLogService.java
  • src/test/java/com/jobdri/jobdri_api/domain/auth/service/AuthServiceTest.java
📝 Walkthrough

Walkthrough

AuthService에 로그인 성공 감사 로그 기록을 추가했다. 로컬 로그인과 Google 소셜 로그인 테스트는 토큰 발급, Redis refresh token 저장, 감사 로그 기록을 검증한다. 감사 로그 기록 실패는 로그인 결과에 영향을 주지 않는다.

Changes

로그인 감사 로그

Layer / File(s) Summary
로그인 성공 감사 로그 연동
src/main/java/com/jobdri/jobdri_api/domain/auth/service/AuthService.java
AuthService가 로그인 성공 후 사용자 ID와 로그인 방식을 AuditLogService에 전달한다. 감사 로그 기록 중 RuntimeException이 발생하면 경고 로그만 기록한다.
로그인 감사 로그 검증
src/test/java/com/jobdri/jobdri_api/domain/auth/service/AuthServiceTest.java
로컬 로그인과 Google 소셜 로그인에서 토큰 반환, Redis refresh token 저장, LOGIN_SUCCESS 감사 로그 기록을 검증한다.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested labels: ✨ feat

Suggested reviewers: whc9999

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning 템플릿 구조는 있으나 작업 내용, 스크린샷, 테스트 결과, 관련 이슈 정보가 작성되지 않았습니다. 구현 내용과 테스트 결과를 작성하고, 필요한 경우 스크린샷과 관련 이슈 번호를 추가하세요.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed 제목은 로그인 성공 시 MAU 감사 로그를 추가하는 주요 변경 사항을 명확하게 나타냅니다.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/audit-mau

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/main/java/com/jobdri/jobdri_api/domain/auth/service/AuthService.java`:
- Around line 270-282: Separate audit-log persistence from the login
transaction: update AuthService.recordLoginSuccess and the audit-log recording
flow so AuditLogService.record runs with REQUIRES_NEW, while preserving the
existing exception handling and allowing login token issuance to commit when
audit recording fails. In AuthServiceTest, replace or extend the current
mock-success coverage with a Spring integration test that forces audit recording
to throw, verifies the exception is contained, and confirms the business login
transaction still commits; apply changes in
src/main/java/com/jobdri/jobdri_api/domain/auth/service/AuthService.java lines
270-282 and
src/test/java/com/jobdri/jobdri_api/domain/auth/service/AuthServiceTest.java
lines 91-148.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: ce96abbb-5f6b-481f-9fe3-23a60a1f7b5e

📥 Commits

Reviewing files that changed from the base of the PR and between 81be0cb and 465a1d1.

📒 Files selected for processing (2)
  • src/main/java/com/jobdri/jobdri_api/domain/auth/service/AuthService.java
  • src/test/java/com/jobdri/jobdri_api/domain/auth/service/AuthServiceTest.java

@shinae1023
shinae1023 merged commit 1ef3f11 into dev Aug 1, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant