[Feat] mau 감사 로그 - #259
Conversation
|
Warning Review limit reached
Next review available in: 47 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthrough
Changes로그인 감사 로그
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/main/java/com/jobdri/jobdri_api/domain/auth/service/AuthService.java`:
- Around line 270-282: Separate audit-log persistence from the login
transaction: update AuthService.recordLoginSuccess and the audit-log recording
flow so AuditLogService.record runs with REQUIRES_NEW, while preserving the
existing exception handling and allowing login token issuance to commit when
audit recording fails. In AuthServiceTest, replace or extend the current
mock-success coverage with a Spring integration test that forces audit recording
to throw, verifies the exception is contained, and confirms the business login
transaction still commits; apply changes in
src/main/java/com/jobdri/jobdri_api/domain/auth/service/AuthService.java lines
270-282 and
src/test/java/com/jobdri/jobdri_api/domain/auth/service/AuthServiceTest.java
lines 91-148.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: ce96abbb-5f6b-481f-9fe3-23a60a1f7b5e
📒 Files selected for processing (2)
src/main/java/com/jobdri/jobdri_api/domain/auth/service/AuthService.javasrc/test/java/com/jobdri/jobdri_api/domain/auth/service/AuthServiceTest.java
✨ 어떤 이유로 PR를 하셨나요?
📋 세부 내용 - 왜 해당 PR이 필요한지 작업 내용을 자세하게 설명해주세요
📸 작업 화면 스크린샷
🚨 관련 이슈 번호 [ ]
Summary by CodeRabbit