Multiple extension installations - #971
Open
kronosapiens wants to merge 11 commits into
Open
Conversation
kronosapiens
force-pushed
the
feat/multiple-extensions
branch
3 times, most recently
from
June 30, 2021 21:19
d96e4b8 to
f96a680
Compare
kronosapiens
marked this pull request as ready for review
June 30, 2021 21:26
kronosapiens
force-pushed
the
feat/multiple-extensions
branch
from
July 1, 2021 23:42
f96a680 to
f4ebba5
Compare
Contributor
Author
|
@area Ah good observation, I had not thought about the network/colony upgrade discrepancy. Perhaps we can add a version check in |
kronosapiens
force-pushed
the
feat/multiple-extensions
branch
5 times, most recently
from
July 8, 2021 22:54
b7e6ec1 to
adb422e
Compare
kronosapiens
force-pushed
the
feat/multiple-extensions
branch
2 times, most recently
from
July 13, 2021 02:29
9f52e61 to
952344e
Compare
kronosapiens
force-pushed
the
feat/multiple-extensions
branch
3 times, most recently
from
July 27, 2021 23:45
56d1f4a to
89f9921
Compare
kronosapiens
force-pushed
the
feat/multiple-extensions
branch
from
August 3, 2021 17:38
89f9921 to
ca0dd96
Compare
kronosapiens
force-pushed
the
feat/multiple-extensions
branch
from
August 11, 2021 22:40
34df2d0 to
a76b8b8
Compare
kronosapiens
force-pushed
the
feat/multiple-extensions
branch
from
August 12, 2021 19:22
a76b8b8 to
30c0a32
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #968
Change internal network-level extension bookkeeping to support an arbitrary number of simultaneous extensions with the same identifier. Backwards-compatible with existing extensions.
New functionality is oriented around the
addressof the extension, rather than thebytes32identifier, so all extension-management functions (upgradeExtension, etc) now call for theaddressof the extension.To check if an extension is installed, use
getExtensionColony, passing in the address of the extension. The function will return the address of the installed colony, if installed.