added: MultipleShooting support for the MovingHorizonEstimator 🍾 - #411
Merged
Conversation
Ooof everything is more complex with the MHE, the growing windows complexify everything.
It is not strictly needed and it's an addition maintainability burden.
It was deleted by mistake.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #411 +/- ##
==========================================
- Coverage 98.65% 98.20% -0.46%
==========================================
Files 27 29 +2
Lines 5730 6130 +400
==========================================
+ Hits 5653 6020 +367
- Misses 77 110 +33 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Benchmark Results (Julia v1)Time benchmarks
Memory benchmarks
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a humongous PR to introduce the support of a
MultipleShootingtranscription in theMovingHorizonEstimator, both forLinModel(QP) andNonLinModel(NLP). There is a newtranscriptionkeyword argument that supports onlySingleShootingandMultipleShootingfor now. This is a huge step toward #332 since theOrthogonalCollocationshould be quite easy to implement now that the machinery for the linear and nonlinear equality constraints is there (it was non-existing before this PR). It is now fully functional and the new dimensions are pretty-printed in theoptimization:section (similarly toNonLinMPC):