debug: do not increment mhe.Nk if updatestate! was not called and direct=true - #417
Closed
franckgaga wants to merge 2 commits into
Closed
debug: do not increment mhe.Nk if updatestate! was not called and direct=true#417franckgaga wants to merge 2 commits into
mhe.Nk if updatestate! was not called and direct=true#417franckgaga wants to merge 2 commits into
Conversation
This is a minor debug to ensure that the length of the data windows are not incremented if the user did not called `updatestate!` on a `MovingHorizonEstimator` with `direct=true`. This should not happen on normal usage of the package. This is however useful for benchmarking. We can call `preparestate!` multiple time (e.g. with `@btime`) and the data windows will be identical at each call.
mhe.Nk if updatestate! was not called and mhe.direct == truemhe.Nk if updatestate! was not called and direct=true
Member
Author
|
Come to think of it, it would create an inconsistency between edit: and the other option of not incrementing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a minor debug to ensure that the length of the data windows are not incremented if the user did not called
updatestate!on aMovingHorizonEstimatorwithdirect=true. This should not happen on normal usage of the package. This is however useful for benchmarking. Now we can callpreparestate!multiple time (e.g. with@btime) and the data windows will be identical at each call.