Skip to content

Add named views to export command #1248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alteous wants to merge 1 commit into from
Closed

Add named views to export command #1248

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion modeling-cmds/src/def_enum.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ use crate::{self as kittycad_modeling_cmds};

define_modeling_cmd_enum! {
pub mod each_cmd {
use std::collections::HashSet;
use std::collections::{HashMap, HashSet};

use bon::Builder;
use crate::{self as kittycad_modeling_cmds};
Expand Down Expand Up @@ -666,6 +666,9 @@ define_modeling_cmd_enum! {
pub entity_ids: Vec<Uuid>,
/// The file format to export to.
pub format: OutputFormat3d,
/// Named viewpoints.
#[builder(default)]
pub views: HashMap<String, CameraViewState>,

@alteous alteous Jun 19, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reused CameraViewState for the time being but I'm wondering whether to create a separate data structure instead. In particular, I take issue with the coordinate system being present and fields for perspective projection being mixed with those for an orthographic projection.

}

/// Export the scene to a file.
Expand Down
Loading