Repository navigation
Conversation
Member
|
Hi @Marco1410, thanks for catching this. I pushed two commits top of yours, hope that's OK. Passing This works on master and fails with Instead of a placeholder, the dummy simulations now receive an actual parameter,
This fixes your case and also the case where |
Member
|
It passes all the tests including the edge case. We move forward by approcing this Fast PR |
Rbravo555
approved these changes
Oct 9, 2026
Rbravo555
deleted the
RomManager_InitializeDummySimulation_CustomizeSimulation_fix
branch
October 9, 2026 15:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
An empty list is added to calls to
CustomizeSimulationinInitializeDummySimulation'sto avoid the missing argument error "CustomizeSimulation() missing 1 required positional argument: 'mu'" when starting a simulation withRomManager.