Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The user provided a list of files, and the issue is about conflicting functions in turbojpeg. I remember that in C, when you have multiple functions with the same name, you can use function pointers or other mechanisms to handle them, but sometimes they can conflict.
Looking at the files, I see that there's a turbojpeg.c and turbojpeg.h in the common directory. The issue mentions that the exports are conflicting, so I think that means there are duplicate functions being exported.
In the turbojpeg.h file, there are functions like tjEncodeYUV, tjGetColorSpace, etc. I recall that in some libraries, especially when using both the main library and a C++ wrapper, functions might be duplicated, causing conflicts.
So, the problem is likely that the same functions are defined in both the main C file and the C++ wrapper, leading to duplicate symbols when building.
The solution would be to consolidate these functions. Maybe the C++ wrapper can include the C functions, or the C functions can be moved to the C++ file. This way, there's no duplication, and the exports are handled correctly.
I think the user wants me to explain this in a clear way, so I'll structure it by identifying the cause and the solution, suggesting that the C++ file should include the C functions or vice versa to eliminate the duplication.
The issue #729 mentions that there are conflicting turbojpeg functions in the exports. This likely occurs because the same functions are defined in both the C and C++ files, leading to duplicate symbols.
Causa:
The functions in
src/common/turbojpeg.candsrc/common/turbojpeg.hare duplicated insrc/common/turbojpeg++.candsrc/common/turbojpeg++.h, causing conflicting exports.Solución:
Consolidar las funciones en un solo archivo. Por ejemplo, mover las funciones de
turbojpeg.caturbojpeg++.cy actualizar los encabezados.