Skip to content

fix: prevent run commands with root when setup environment #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vitormattos wants to merge 5 commits into
base: main
Choose a base branch
from
Open

fix: prevent run commands with root when setup environment #122

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1df5ec1
chore: simplify extra app setup
vitormattos Aug 22, 2026
8e4a8d4
fix: Run git commands using www-data and not root
vitormattos Aug 22, 2026
2527cf3
fix: create folders using www-data and not root
vitormattos Aug 22, 2026
617d068
fix: No more necessary
vitormattos Aug 22, 2026
61ff1e1
fix: this app need the vendor folder
vitormattos Aug 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 19 additions & 28 deletions .docker/scripts/nextcloud-entrypoint.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,18 +6,20 @@ groupmod --non-unique --gid "${HOST_GID}" www-data

# Clone Nextcloud repository, if needed
if [ ! -d ".git" ]; then
git config --global --add safe.directory /var/www/html
git init
git remote add origin https://github.com/nextcloud/server
git fetch --depth=1 origin "${VERSION_NEXTCLOUD}"
git checkout "${VERSION_NEXTCLOUD}"
git submodule update --init --recursive
chown -R www-data:www-data .
runuser -u www-data -- git config --global --add safe.directory /var/www/html
runuser -u www-data -- git init
runuser -u www-data -- git remote add origin https://github.com/nextcloud/server
runuser -u www-data -- git fetch --depth=1 origin "${VERSION_NEXTCLOUD}"
runuser -u www-data -- git checkout "${VERSION_NEXTCLOUD}"
runuser -u www-data -- git submodule update --init --recursive
fi

mkdir -p data
mkdir -p apps-writable
mkdir -p config
mkdir -p apps-extra
install -d -o www-data -g www-data \
data \
apps-writable \
config \
apps-extra

# Wait for database
php /var/www/scripts/wait-for-db.php
Expand All @@ -33,7 +35,6 @@ fi
# Set configurations, if needed
if [[ ! -f "config/config.php" && ${AUTOINSTALL} -eq 1 ]]; then
echo "⌛️ Starting installation ..."
chown -R www-data:www-data .
if [[ ${DB_HOST} == 'mysql' ]]; then
occ maintenance:install --verbose --database="${DB_HOST}" --database-name="${MYSQL_DATABASE}" --database-host="${DB_HOST}" --database-port= --database-user="${MYSQL_USER}" --database-pass="${MYSQL_PASSWORD}" --admin-user="${NEXTCLOUD_ADMIN_USER}" --admin-pass="${NEXTCLOUD_ADMIN_PASSWORD}" --admin-email="${NEXTCLOUD_ADMIN_EMAIL}"
install_cmd_status=$?
Expand Down Expand Up @@ -105,31 +106,21 @@ EOF

if [ ! -d "apps-extra/hmr_enabler" ]; then
echo "⌛️ Installing hmr_enabler app to be possible use Vue Developer Tools"
git clone --progress --single-branch --depth 1 https://github.com/nextcloud/hmr_enabler apps-extra/hmr_enabler
composer -d apps-extra/hmr_enabler/ i
occ app:enable hmr_enabler
runuser -u www-data -- git clone --progress --single-branch --depth 1 https://github.com/nextcloud/hmr_enabler apps-extra/hmr_enabler
runuser -u www-data -- composer install --working-dir=apps-extra/hmr_enabler
runuser -u www-data -- occ app:enable hmr_enabler
fi

if [ ! -d "apps-extra/viewer" ]; then
echo "⌛️ Installing viewer app..."
git clone --progress --single-branch --depth 1 https://github.com/nextcloud/viewer apps-extra/viewer
cd apps-extra/viewer || exit
composer i
npm ci
npm run build
cd ../../ || exit
occ app:enable viewer
runuser -u www-data -- git clone --progress --single-branch --depth 1 https://github.com/nextcloud/viewer apps-extra/viewer
runuser -u www-data -- occ app:enable viewer
fi

if [ ! -d "apps-extra/files_pdfviewer" ]; then
echo "⌛️ Installing files_pdfviewer app..."
git clone --progress --single-branch --depth 1 https://github.com/nextcloud/files_pdfviewer apps-extra/files_pdfviewer
cd apps-extra/files_pdfviewer || exit
composer i
npm ci
npm run build
cd ../../ || exit
occ app:enable files_pdfviewer
runuser -u www-data -- git clone --progress --single-branch --depth 1 https://github.com/nextcloud/files_pdfviewer apps-extra/files_pdfviewer
runuser -u www-data -- occ app:enable files_pdfviewer
fi

echo "🥳 Setup completed !!!"
Expand Down