Skip to content

feat(l10n): add TRANSLATORS hints for signing engine strings - #8015

Merged
vitormattos merged 1 commit into
LibreSign:mainfrom
lfals:feat/php-translation-hints-973-batch-sign-engine
Aug 22, 2026
Merged

feat(l10n): add TRANSLATORS hints for signing engine strings#8015
vitormattos merged 1 commit into
LibreSign:mainfrom
lfals:feat/php-translation-hints-973-batch-sign-engine

Conversation

@lfals

@lfals lfals commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Resolves: #973

📝 Summary

Adds 15 // TRANSLATORS comments for PHP signing-engine strings in:

  • lib/Handler/SignEngine/Pkcs12Handler.php (signature validation labels and engine errors)
  • lib/Handler/SignEngine/SignEngineHandler.php (certificate generation, PFX storage, signing password errors)

Hints give LibreSign context for translators (validation UI / signer certificate workflow) without changing English source strings. This is a 15-hint batch for #973.

Comments will appear in Transifex after the next extraction sync.

🧪 How to test

  1. Open the two files above and confirm each changed $this->l10n->t(...) has a // TRANSLATORS comment on the line above.
  2. Confirm the diff is comments only — no English source strings changed.
  3. Optional: open LibreSign document validation for a signed PDF and confirm status labels still read the same in English.

⚙️ API / Back‑end changes

  • Added PHP TRANSLATORS hints for signing-engine validation and certificate/password errors
  • Unit and/or integration tests added – N/A: comment-only change; no behavior change
  • Capabilities updated (if applicable)
  • Documentation updated (if applicable)
  • API documentation updated with composer openapiN/A

✅ Checklist

🤖 AI (if applicable)

  • The content of this PR was partially or fully generated using AI

Made with Cursor

Help translators with LibreSign signature validation labels and
certificate/password errors used while generating or unlocking PFX.

Signed-off-by: Luis Amorim <luisfelipeamorim@hotmail.com>
@github-project-automation github-project-automation Bot moved this to 0. Backlog in Roadmap Aug 21, 2026
@lfals
lfals marked this pull request as ready for review August 21, 2026 23:48
@github-project-automation github-project-automation Bot moved this from 0. Backlog to 1. to do in Roadmap Aug 22, 2026
@vitormattos

Copy link
Copy Markdown
Member

/backport to stable34

@vitormattos

vitormattos commented Aug 22, 2026

Copy link
Copy Markdown
Member

/backport to stable33

@vitormattos

Copy link
Copy Markdown
Member

/backport to stable32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 4. to release

Development

Successfully merging this pull request may close these issues.

Implement translation hints in PHP

2 participants