feat(l10n): add TRANSLATORS hints for signing engine strings - #8015
Merged
vitormattos merged 1 commit intoAug 22, 2026
Merged
Conversation
Help translators with LibreSign signature validation labels and certificate/password errors used while generating or unlocking PFX. Signed-off-by: Luis Amorim <luisfelipeamorim@hotmail.com>
vitormattos
approved these changes
Aug 22, 2026
Member
|
/backport to stable34 |
Member
|
/backport to stable33 |
Member
|
/backport to stable32 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #973
📝 Summary
Adds 15
// TRANSLATORScomments for PHP signing-engine strings in:lib/Handler/SignEngine/Pkcs12Handler.php(signature validation labels and engine errors)lib/Handler/SignEngine/SignEngineHandler.php(certificate generation, PFX storage, signing password errors)Hints give LibreSign context for translators (validation UI / signer certificate workflow) without changing English source strings. This is a 15-hint batch for #973.
Comments will appear in Transifex after the next extraction sync.
🧪 How to test
$this->l10n->t(...)has a// TRANSLATORScomment on the line above.⚙️ API / Back‑end changes
TRANSLATORShints for signing-engine validation and certificate/password errorscomposer openapi– N/A✅ Checklist
feat)🤖 AI (if applicable)
Made with Cursor