Skip to content

feat(l10n): add TRANSLATORS hints for footer, SMS and PDFtk - #8016

Merged
vitormattos merged 1 commit into
LibreSign:mainfrom
lfals:feat/php-translation-hints-973-batch-footer-pdftk
Aug 22, 2026
Merged

feat(l10n): add TRANSLATORS hints for footer, SMS and PDFtk#8016
vitormattos merged 1 commit into
LibreSign:mainfrom
lfals:feat/php-translation-hints-973-batch-footer-pdftk

Conversation

@lfals

@lfals lfals commented Aug 22, 2026

Copy link
Copy Markdown
Contributor

Resolves: #973

📝 Summary

Adds 20 // TRANSLATORS comments for PHP strings across LibreSign footer stamping, signer SMS/gateway notifications, Activity settings, admin settings section naming, and PDFtk administration overview checks:

  • lib/Handler/FooterHandler.php
  • lib/Listener/TwofactorGatewayListener.php
  • lib/Handler/PdfTk/Pdf.php
  • lib/Activity/Settings/FileSigned.php
  • lib/Activity/Settings/FileToSign.php
  • lib/Activity/Settings/SignRequestCanceled.php
  • lib/Settings/AdminSettings.php
  • lib/SetupCheck/PDFtkSetupCheck.php

Hints give LibreSign context for translators without changing English source strings. This is a 20-hint batch for #973.

Comments will appear in Transifex after the next extraction sync.

🧪 How to test

  1. Review the files listed above and confirm each changed $this->l10n->t(...) / $this->l->t(...) has a // TRANSLATORS comment on the line above.
  2. Confirm the diff is comments only — no English source strings changed.
  3. Optional:
    • Open Nextcloud Administration settings → Overview and confirm PDFtk LibreSign messages still render the same English text.
    • Open Personal settings → Activity and confirm LibreSign activity setting labels still look the same.

⚙️ API / Back‑end changes

  • Added PHP TRANSLATORS hints for footer defaults, Twofactor Gateway messages, Activity settings, admin section name, and PDFtk setup-check strings
  • Unit and/or integration tests added – N/A: comment-only change; no behavior change
  • Capabilities updated (if applicable)
  • Documentation updated (if applicable)
  • API documentation updated with composer openapiN/A

✅ Checklist

🤖 AI (if applicable)

  • The content of this PR was partially or fully generated using AI

Made with Cursor

Help translators with LibreSign PDF footer defaults, Twofactor Gateway
signing messages, Activity settings, admin section name, and PDFtk
setup-check strings.

Signed-off-by: Luis Amorim <luisfelipeamorim@hotmail.com>
@github-project-automation github-project-automation Bot moved this to 0. Backlog in Roadmap Aug 22, 2026
@lfals
lfals marked this pull request as ready for review August 22, 2026 00:07
@github-project-automation github-project-automation Bot moved this from 0. Backlog to 1. to do in Roadmap Aug 22, 2026
@vitormattos

Copy link
Copy Markdown
Member

/backport to stable34

@vitormattos

Copy link
Copy Markdown
Member

/backport to stable33

@vitormattos

Copy link
Copy Markdown
Member

/backport to stable32

@vitormattos
vitormattos merged commit 155d1c5 into LibreSign:main Aug 22, 2026
72 of 73 checks passed
@github-project-automation github-project-automation Bot moved this from 1. to do to 4. to release in Roadmap Aug 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 4. to release

Development

Successfully merging this pull request may close these issues.

Implement translation hints in PHP

2 participants