rt-tests: Rename PRIORITY -> RT_PRIORITY - #642
sebastianas wants to merge 1 commit into
Conversation
The cyclictest command is run a low task priority. From the output in the test I see | / # /lava-22804428/bin/lava-test-runner /lava-22804428/0 | + export TESTRUN_ID=0_rt-tests-cyclictest | + TESTRUN_ID=0_rt-tests-cyclictest | + cd /lava-22804428/0/tests/0_rt-tests-cyclictest | ++ cat uuid | + UUID=22804428_1.1.4.1 | + set +x | <LAVA_SIGNAL_STARTRUN 0_rt-tests-cyclictest 22804428_1.1.4.1> | + cd ./automated/linux/cyclictest/ | + ./cyclictest.sh -D 540s -p 48 -i 1000 -t 2 -a 0 -h '' -w hackbench | Received signal: <STARTRUN> 0_rt-tests-cyclictest 22804428_1.1.4.1 | Starting test lava.0_rt-tests-cyclictest (22804428_1.1.4.1) | Skipping test definition patterns. | # /dev/cpu_dma_latency set to 0us | T: 0 ( 437) P:48 I:1000 C: 540000 Min: 4 Act: 5 Avg: 18 Max: 217 | T: 1 ( 438) P:48 I:1500 C: 360000 Min: 4 Act: 9 Avg: 17 Max: 340 | t0-min-latency pass 4 us | t0-avg-latency pass 18.29 us | t0-max-latency pass 217 us | t1-min-latency pass 4 us | t1-avg-latency pass 17.69 us | t1-max-latency pass 340 us | cyclictest pass and the test definition has | name: rt-tests-cyclictest | parameters: … | PRIORITY: 48 … | status: finished | priority: 48 | timeouts: I think that PRIORITY and priority arguments are getting confused and instead of the cylictest priority it is using the scheduling priority. Rename PRIORITY to RT_PRIORITY Link: https://lava.collabora.dev/scheduler/job/22804428/definition Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
|
I have a counterpart change in kernelci/kernelci-core#3203. Is there Linaro repository that would need this, too? |
No, it's fine to keep it in KCI; the test-definitions home is here. We will need to update test-def's when we do our next release here to take on the changes. But I can do that once this PR goes through + we do a release. |
|
I can't access the link: https://lava.collabora.dev/scheduler/job/22804428/definition |
Yeah, I can't access it myself either. https://dashboard.kernelci.org/test/maestro%3A6aa749c920239ade9030ea09 holds some of the test resuts here. The job_url there is login only now. There is lava_logs, callback_data and log_excerpt. In log_excerpt you see so PRIORITY was 52. In lava_callback you see So it appears to me as if those two got merged. I don't see where is 52 should come from other than the scheduling priority. Sebastian |
The cyclictest command is run a low task priority. From the output in the test I see
| / # /lava-22804428/bin/lava-test-runner /lava-22804428/0 | + export TESTRUN_ID=0_rt-tests-cyclictest
| + TESTRUN_ID=0_rt-tests-cyclictest
| + cd /lava-22804428/0/tests/0_rt-tests-cyclictest | ++ cat uuid
| + UUID=22804428_1.1.4.1
| + set +x
| <LAVA_SIGNAL_STARTRUN 0_rt-tests-cyclictest 22804428_1.1.4.1> | + cd ./automated/linux/cyclictest/
| + ./cyclictest.sh -D 540s -p 48 -i 1000 -t 2 -a 0 -h '' -w hackbench | Received signal: 0_rt-tests-cyclictest 22804428_1.1.4.1 | Starting test lava.0_rt-tests-cyclictest (22804428_1.1.4.1) | Skipping test definition patterns.
| # /dev/cpu_dma_latency set to 0us
| T: 0 ( 437) P:48 I:1000 C: 540000 Min: 4 Act: 5 Avg: 18 Max: 217
| T: 1 ( 438) P:48 I:1500 C: 360000 Min: 4 Act: 9 Avg: 17 Max: 340
| t0-min-latency pass 4 us
| t0-avg-latency pass 18.29 us
| t0-max-latency pass 217 us
| t1-min-latency pass 4 us
| t1-avg-latency pass 17.69 us
| t1-max-latency pass 340 us
| cyclictest pass
and the test definition has
| name: rt-tests-cyclictest
| parameters:
…
| PRIORITY: 48
…
| status: finished
| priority: 48
| timeouts:
I think that PRIORITY and priority arguments are getting confused and instead of the cylictest priority it is using the scheduling priority.
Rename PRIORITY to RT_PRIORITY
Link: https://lava.collabora.dev/scheduler/job/22804428/definition