Test dockerfile plan - #644
Merged
Merged
Conversation
roxell
force-pushed
the
test-dockerfile-plan
branch
from
September 23, 2026 21:34
04265f7 to
5cbbd04
Compare
Contributor
|
@roxell what is the goal of this series? Could you add description to the PR? |
mwasilew
approved these changes
Sep 25, 2026
roxell
force-pushed
the
test-dockerfile-plan
branch
2 times, most recently
from
September 28, 2026 08:26
fd52f52 to
48c30c8
Compare
plans/linux-example.yaml is gone, so test-runner stops with "NOT found" in both test Dockerfiles. Use plans/linux-test-plan-example.yaml instead. Fixes: dca4fb6 ("plans: introduce linaro test plan v2") Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
The examples still use the removed plans/linux-example.yaml. The overlay example also misses the plans/ directory, so it never worked. Fix both paths. Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
"FROM centos" fails to build, the image is gone from Docker Hub. Use fedora:44 instead. The pinned tag lets dependabot bump it. Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
dnf5 in Fedora 41 and later does not know -e, so install_deps fails on every Fedora install. Drop it. Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
redhat-lsb-core is gone since Fedora 38 and EL9, so dist_info() fails to install it. Install /usr/bin/lsb_release and let dnf or yum pick the package. Fix the example in the test writing guidelines too. Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
smoke.sh has the same redhat-lsb-core problem, so the smoke test fails on Fedora 38+ and EL9. Install /usr/bin/lsb_release, like sh-test-lib does. Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
roxell
force-pushed
the
test-dockerfile-plan
branch
from
September 28, 2026 08:37
48c30c8 to
4d5d19d
Compare
test.sh ran validate.py with its own list of ignored checks. That list was older than the one in sanity-check.sh and missed SC3043, so a local run failed on every script that uses 'local'. Call sanity-check.sh so the local run and CI use the same checks. Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
shellcheck 0.11 adds SC3014 for == in [[ ]], so sanity-check.sh fails. The file disables the SC3xxx checks one by one, and each new shellcheck release can add more. The script runs in mksh, so tell shellcheck it is ksh and drop the SC3xxx disables. Drop SC2039 too, it does nothing. Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
bhcopeland
approved these changes
Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was reviewing PR-641 and I wanted to run test.sh, and the goal was to get it test.sh to work again. It build a container and runs test-runner inside it, so we can try test changes locally. Right now it is broken in several places.