Start of CI, dependency, and build modernization - #210
Closed
Michiel-VandeVelde wants to merge 1 commit into
Closed
Conversation
Author
|
closing, targeted the wrong branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This continues the CI/dependency modernization from #209 as a start for the modernization, targeting the shared modernize-repository branch @jitsedesmet made upstream.
Covers: GitHub Actions bumped to non-deprecated versions targeting Node.js 24, Docker base image updated to node:22-slim, HDT's native build fixed for modern Node, sinon/sinon-chai modernization attempted then reverted (pinned sinon-chai to 2.14.0 instead the newer sinon API broke stub.reset() usage elsewhere), and lerna pinned to a version that keeps HDT's native build working at the root.
Recap from #209 that PR flagged that referencing this fork's own PR from a commit message with a bare #N will auto-link to an unrelated issue/PR once the commit lands in LinkedDataFragments/Server.js, since GitHub resolves #N against whichever repo it's viewed in. @rubensworks fix: use the cross-repo form Michiel-VandeVelde/Server.js#N instead. this was later discussed and the upstream branch modernize-repository was made to have a cleaner history
Full discussion: #209