fix(ci): build the EE image without the registry prefix - #324
Merged
Conversation
push-to-registry v3 prefixes its push source with localhost/, while its existence check keeps using the bare `image` input, which podman also resolves to a local ghcr.io/... image. An image built as ghcr.io/<owner>/lfops_ee therefore passes the check and fails the push with "image not known". Building it unqualified puts it under localhost/, where both steps find it. Works with the currently pinned v2.8 as well, so it can land before the bump does.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prepares
lf-build.ymlforredhat-actions/push-to-registryv3, which #319 wants to bump to.v3 prefixes its push source with
localhost/(upstream issue #66,src/index.ts:328), while its existence check keeps using the bareimageinput, which podman also resolves to a localghcr.io/...image. The EE was built asghcr.io/<owner>/lfops_ee, so under v3 the check would pass and the push would fail withimage not known. That failure would only surface during a release, after the collection is already on Galaxy.Building the image unqualified stores it under
localhost/, where both the check and the push find it.Verified with podman 5.8.4 on Fedora 44:
podman image exists <owner>/lfops_ee:<tag>→ rc=0 for both tagspodman push localhost/<owner>/lfops_ee:<tag>→ rc=0 for both tags, the v3 pathpodman push <owner>/lfops_ee:<tag>→ rc=0, the v2.8 path, so this works with the currently pinned version tooansible-builderpasses--tagstraight topodman build -twithout normalising it (src/ansible_builder/main.py:196).