Conversation
hjpalpha
approved these changes
Sep 20, 2026
steve020607
approved these changes
Sep 20, 2026
ElectricalBoy
left a comment
ElectricalBoy
left a comment
Collaborator
There was a problem hiding this comment.
not a fan
see previous discussions:
ElectricalBoy
changed the title
Collaborator
imo worth it if they finally start using match2 |
Collaborator
Author
we'd be fine for now with stretching the bracket, unless we can somehow convince the editor community to move back to numeric scores (at this rate the contributor are still even hanging on the point that they dont see why they should move to M2, and 1 is better. So let alone our attempt to tell them of ditching head scores vs Numbers atm. Probably best to start slo and see how it works out) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This would be a good QoL to go alongside with my attempt at encouraging more Match2 usage on Smash, that is to avoid the clipping names by stretching the matchWidth noticeably, but not too much. It should cover most cases so user dont have to type matchWidth all the time
Note
190 is the value I took from MLBB info file, seems working here